feat: perf(enforce): reuse buffers with sync.Pool to reduce allocations#1696
Merged
hsluoyz merged 2 commits intoapache:masterfrom Jan 26, 2026
Merged
feat: perf(enforce): reuse buffers with sync.Pool to reduce allocations#1696hsluoyz merged 2 commits intoapache:masterfrom
hsluoyz merged 2 commits intoapache:masterfrom
Conversation
AKonnyaku
force-pushed
the
enforcer-test
branch
from
eff4b2e to
e6c2869
Compare
Benchmark ComparisonComparing base branch ( 🤖 This comment will be automatically updated with the latest benchmark results. |
There was a problem hiding this comment.
Pull request overview
Reduces allocations in the enforce hot path by reusing policyEffects and matcherResults slices via sync.Pool, aiming to lower GC pressure under load.
Changes:
- Added global
sync.Poolinstances and helper methods to reusepolicyEffectsandmatcherResultsbuffers. - Updated
enforceto borrow/return buffers instead of allocating slices per call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hsluoyz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local profiling on current master branch showed alloc_space hotspots dominated by make slices inside enforce. Heap profiles traced most churn to policyEffects and matcherResults buffers.