Add GetStrictFilteredPolicy: treat "" as literal empty string, "*" as wildcard#1709
Open
Add GetStrictFilteredPolicy: treat "" as literal empty string, "*" as wildcard#1709
Conversation
|
|
…card Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix GetFilteredPolicy to treat empty string correctly
Add GetStrictFilteredPolicy: treat "" as literal empty string, "*" as wildcard
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetFilteredPolicytreats""as a wildcard (matches any value), making it impossible to query for policy rules where a field is literally an empty string. The issue requests a non-breaking strict variant.Changes
model/policy.go— AddedGetStrictFilteredPolicycore method:""matches only empty-string fields,"*"matches any value. Includes bounds check onfieldIndex+iabsent from the original.management_api.go— Added four newEnforcermethods:GetStrictFilteredPolicy,GetStrictFilteredNamedPolicy,GetStrictFilteredGroupingPolicy,GetStrictFilteredNamedGroupingPolicyenforcer_interface.go— ExtendedIEnforcerwith the four new methodsenforcer_synced.go— Added thread-safe wrappers onSyncedEnforcerfor all four methodsBehaviour contrast
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.