CASSSIDECAR-331: NullPointerException When Authentication Is Enabled but sidecar_internal Schema Is Disabled #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarankk
force-pushed
the
fix_jira
branch
2 times, most recently
from
8135f4b to
e535fba
Compare
frankgh
reviewed
Aug 15, 2025
Contributor
frankgh
left a comment
frankgh
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the fix. I have small comments
.../main/java/org/apache/cassandra/sidecar/acl/authentication/AuthenticationHandlerFactory.java
Show resolved
Hide resolved
...in/java/org/apache/cassandra/sidecar/acl/authentication/JwtAuthenticationHandlerFactory.java
Outdated
Show resolved
Hide resolved
...a/org/apache/cassandra/sidecar/acl/authentication/MutualTlsAuthenticationHandlerFactory.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/cassandra/sidecar/modules/AuthModule.java
Outdated
Show resolved
Hide resolved
…nal Schema Is Disabled
…Module.java Co-authored-by: Francisco Guerrero <frank.guerrero@gmail.com>
…cation/MutualTlsAuthenticationHandlerFactory.java Co-authored-by: Francisco Guerrero <frank.guerrero@gmail.com>
…cation/JwtAuthenticationHandlerFactory.java Co-authored-by: Francisco Guerrero <frank.guerrero@gmail.com>
…cation/AuthenticationHandlerFactory.java Co-authored-by: Francisco Guerrero <frank.guerrero@gmail.com>
bbotella
reviewed
Sep 2, 2025
| * Invalidate a key. | ||
| * @param k key to invalidate | ||
| */ | ||
| public void invalidate(K k) |
Contributor
There was a problem hiding this comment.
Where is this method being used?
Comment on lines
+73
to
+79
| boolean isSidecarSchemaEnabled = sidecarConfiguration.serviceConfiguration() | ||
| .schemaKeyspaceConfiguration() | ||
| .isEnabled(); | ||
| if (!isSidecarSchemaEnabled) | ||
| { | ||
| throw new ConfigurationException("JwtAuthenticationHandlerFactory requires Sidecar schema to be enabled for role processing"); | ||
| } |
Contributor
There was a problem hiding this comment.
Why not having this implementation in the default implementation of the interface?
Contributor
There was a problem hiding this comment.
I don't think it makes sense to have this in the interface, because you don't know if the implementation requires sidecar schema. It only makes sense to have this check if you require sidecar schema for the implementation
| .isEnabled(); | ||
| if (!isSidecarSchemaEnabled) | ||
| { | ||
| throw new ConfigurationException("MutualTlsAuthenticationHandlerFactory requires Sidecar schema to be enabled for role processing"); |
Contributor
There was a problem hiding this comment.
What about mentioning explicitly the flag that needs to be enabled on the config?
| { | ||
| if (!sidecarConfiguration.serviceConfiguration().schemaKeyspaceConfiguration().isEnabled()) | ||
| { | ||
| throw new ConfigurationException(config.className() + " requires Sidecar schema to be enabled for role permissions used by Sidecar"); |
Contributor
There was a problem hiding this comment.
What about mentioning explicitly the flag that needs to be enabled on the config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.