-
Notifications
You must be signed in to change notification settings - Fork 52
CASSSIDECAR-339: Add developer-facing docs on testing Sidecar #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Patch by Francisco Guerrero; reviewed by TBD for CASSSIDECAR-339
Co-authored-by: Doug Rohrer <682821+JeetKunDoug@users.noreply.github.com>
Co-authored-by: Doug Rohrer <682821+JeetKunDoug@users.noreply.github.com>
JeetKunDoug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together - a bunch of small questions/suggestions.
TESTING.md
Outdated
|
|
||
| ### Required Software | ||
|
|
||
| 1. **Java 11 or higher** (OpenJDK or Oracle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to call out OpenJDK or Oracle? Is this just to try to limit our "support" to those, and avoid other JDKs? Because I don't think we test with Oracle JDK anywhere, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I will remove that reference
| BRANCHES="cassandra-4.1 trunk" ./scripts/build-dtest-jars.sh | ||
| ``` | ||
|
|
||
| ### Network Setup for Multi-Node Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to add entries to /etc/hosts for these to work correctly? I know I did ages ago, and since it's persistent I never touched it again, but I think they are still necessary.
TESTING.md
Outdated
| <logger name="org.apache.cassandra.sidecar" level="DEBUG"/> | ||
| ``` | ||
|
|
||
| ### Performance Testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really "performance testing" in the traditional sense of the word... I'm not sure what it is, other than "Troubleshooting long-running tests,"
TESTING.md
Outdated
| #### Java Version Issues | ||
| - Verify Java 11+ compatibility | ||
| - Check JVM arguments in CI environments | ||
| - Review module path configurations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this is supposed to mean - can we be more descriptive of what "Review module path configurations" means in the context of "environment-specific issues" - are you talking about Classpath issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure actually, I will remove it
Co-authored-by: Doug Rohrer <682821+JeetKunDoug@users.noreply.github.com>
# Conflicts: # TESTING.md
|
|
Patch by Francisco Guerrero; reviewed by TBD for CASSSIDECAR-339