Skip to content

Conversation

@frankgh
Copy link
Contributor

@frankgh frankgh commented Aug 24, 2025

Patch by Francisco Guerrero; reviewed by TBD for CASSSIDECAR-339

Patch by Francisco Guerrero; reviewed by TBD for CASSSIDECAR-339
frankgh and others added 3 commits August 30, 2025 14:39
Co-authored-by: Doug Rohrer <682821+JeetKunDoug@users.noreply.github.com>
Co-authored-by: Doug Rohrer <682821+JeetKunDoug@users.noreply.github.com>
@frankgh frankgh requested a review from JeetKunDoug August 30, 2025 21:46
Copy link
Contributor

@JeetKunDoug JeetKunDoug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together - a bunch of small questions/suggestions.

TESTING.md Outdated

### Required Software

1. **Java 11 or higher** (OpenJDK or Oracle)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to call out OpenJDK or Oracle? Is this just to try to limit our "support" to those, and avoid other JDKs? Because I don't think we test with Oracle JDK anywhere, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will remove that reference

BRANCHES="cassandra-4.1 trunk" ./scripts/build-dtest-jars.sh
```

### Network Setup for Multi-Node Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to add entries to /etc/hosts for these to work correctly? I know I did ages ago, and since it's persistent I never touched it again, but I think they are still necessary.

TESTING.md Outdated
<logger name="org.apache.cassandra.sidecar" level="DEBUG"/>
```

### Performance Testing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really "performance testing" in the traditional sense of the word... I'm not sure what it is, other than "Troubleshooting long-running tests,"

TESTING.md Outdated
#### Java Version Issues
- Verify Java 11+ compatibility
- Check JVM arguments in CI environments
- Review module path configurations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this is supposed to mean - can we be more descriptive of what "Review module path configurations" means in the context of "environment-specific issues" - are you talking about Classpath issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure actually, I will remove it

Co-authored-by: Doug Rohrer <682821+JeetKunDoug@users.noreply.github.com>
@frankgh frankgh requested a review from JeetKunDoug December 1, 2025 13:31
# Conflicts:
#	TESTING.md
@JeetKunDoug
Copy link
Contributor

:shipit: (also commented on the Jira)

@frankgh frankgh merged commit b9919f9 into apache:trunk Dec 1, 2025
4 of 5 checks passed
@frankgh frankgh deleted the CASSSIDECAR-339 branch December 1, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants