CASSSIDECAR-386: Fixing file left opened issue in Sidecar Client #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shruti-p-s
force-pushed
the
CASSIDECAR-386
branch
from
08a2a61 to
e0aa46b
Compare
frankgh
reviewed
Dec 1, 2025
Contributor
frankgh
left a comment
frankgh
left a comment
There was a problem hiding this comment.
Looks good, I have one minor comment
Comment on lines
254
to
258
| .onComplete(ar -> { | ||
| asyncFile.close().onFailure(err -> | ||
| LOGGER.warn("Failed to close file after upload", err) | ||
| ); | ||
| }); |
Contributor
There was a problem hiding this comment.
Can we also log the filename here?
Suggested change
| .onComplete(ar -> { | |
| asyncFile.close().onFailure(err -> | |
| LOGGER.warn("Failed to close file after upload", err) | |
| ); | |
| }); | |
| .onComplete(ar -> asyncFile.close().onFailure(err -> | |
| LOGGER.warn("Failed to close file='{}' after upload", filename, err) | |
| )); |
Contributor
Author
There was a problem hiding this comment.
Good point, I'll add this now, thanks.
added 2 commits
December 1, 2025 14:58
yifan-c
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by Shruti Sekaran; Reviewed by TBD for CASSSIDECAR-386