Skip to content

Changing executeAPI to utilize POST request#18

Merged
yadvr merged 7 commits intoapache:mainfrom
kevin-lii:enforce_post_request
Jul 14, 2025
Merged

Changing executeAPI to utilize POST request#18
yadvr merged 7 commits intoapache:mainfrom
kevin-lii:enforce_post_request

Conversation

@kevin-lii
Copy link
Copy Markdown
Contributor

Changing executeAPI to utilize POST request

Comment thread apirunner/apirunner.go Outdated
Comment thread apirunner/apirunner.go Outdated
Comment thread apirunner/apirunner.go
@kevin-lii
Copy link
Copy Markdown
Contributor Author

This should have resolved the changes

@kevin-lii kevin-lii requested review from sureshanaparti and yadvr May 13, 2025 00:30
Comment thread apirunner/apirunner.go Outdated
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Comment thread apirunner/apirunner.go Outdated
Comment thread apirunner/apirunner.go Outdated
Comment thread apirunner/apirunner.go Outdated
Comment thread apirunner/apirunner.go Outdated
Copy link
Copy Markdown
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested by building the cs-bench binary locally

  1. Clone the Cloudstack go repo and cloudstack csbench repo

  2. Navigate into cs bench repo

  3. vi go.mod
    replace http://github.com/apache/cloudstack-go/v2 => /Users/kiranchavala/Desktop/cloudstack-go

  4. go mod tidy

  5. go build

  6. Set the global setting value to true for enforce.post.requests.and.timestamps

  7. ./csbench -create -domain -limits -network -vm -volume

The tool worked successfully

Comment thread apirunner/apirunner.go Outdated
@yadvr yadvr merged commit e495242 into apache:main Jul 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants