Skip to content

Update integrations#337

Merged
DaanHoogland merged 1 commit intoapache:staging-sitefrom
shapeblue:update-integrations-page
Jul 2, 2025
Merged

Update integrations#337
DaanHoogland merged 1 commit intoapache:staging-sitefrom
shapeblue:update-integrations-page

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Jul 1, 2025

This PR adds new entries in Integrations page and also some new features around it. When you click on the image for an integration, it will now open a modal with a description.

Also refactored the code to generate the integration entries using a JSON object.

@vishesh92 vishesh92 requested a review from Copilot July 1, 2025 12:39

This comment was marked as outdated.

@vishesh92 vishesh92 force-pushed the update-integrations-page branch from ea688fc to 6c3c0e7 Compare July 2, 2025 05:55
@vishesh92 vishesh92 requested a review from Copilot July 2, 2025 05:55

This comment was marked as outdated.

@vishesh92 vishesh92 force-pushed the update-integrations-page branch from 6c3c0e7 to d8ae9a6 Compare July 2, 2025 06:07
@vishesh92 vishesh92 force-pushed the update-integrations-page branch from d8ae9a6 to f6c2cfe Compare July 2, 2025 07:18
@vishesh92 vishesh92 requested a review from Copilot July 2, 2025 07:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Integrations page to drive content from a JSON configuration and introduces a modal dialog for detailed integration descriptions.

  • Introduces SimpleMarkdown for basic markdown rendering and modal functionality for integration items.
  • Replaces hardcoded tab content with dynamic rendering using integrationConfig.
  • Adds dynamic style injection for hover effects and updates CSS for responsive images.

Reviewed Changes

Copilot reviewed 2 out of 7 changed files in this pull request and generated 3 comments.

File Description
src/pages/integrations.js Added JSON-driven integration rendering, modal logic, markdown parser, and inline style injection
src/css/custom.css Extended styles for .tab-box img and added .box-linbit color
Comments suppressed due to low confidence (2)

src/pages/integrations.js:1

  • Missing import of React; add import React from 'react'; at the top to ensure React.useState and React.useEffect work correctly.
import React from 'react';

src/pages/integrations.js:542

  • [nitpick] The key 'stack console' contains a space and is inconsistent with other identifiers; consider using a hyphenated or camelCase key for reliability.
        },

Comment thread src/pages/integrations.js
const [modalContent, setModalContent] = React.useState({});

// Add hover styles and clickable indicators
React.useEffect(() => {
Copy link

Copilot AI Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Injecting large CSS blocks via JavaScript can complicate maintenance and cause flash-of-unstyled-content; consider moving these styles into your external CSS file.

Copilot uses AI. Check for mistakes.
Comment thread src/pages/integrations.js
},
{
key: "vmware-nsx",
title: "Vmware NSX",
Copy link

Copilot AI Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product name 'Vmware NSX' has incorrect casing; it should be 'VMware NSX' to match official branding.

Suggested change
title: "Vmware NSX",
title: "VMware NSX",

Copilot uses AI. Check for mistakes.
Comment thread src/pages/integrations.js
Comment on lines +825 to +846
<div className="modal-overlay" onClick={closeModal} style={{
position: 'fixed',
top: 0,
left: 0,
right: 0,
bottom: 0,
backgroundColor: 'rgba(0, 0, 0, 0.5)',
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
zIndex: 1000
}}>
<div className="modal-content" onClick={(e) => e.stopPropagation()} style={{
backgroundColor: 'white',
padding: '2rem',
borderRadius: '8px',
maxWidth: '600px',
width: '90%',
maxHeight: '80vh',
overflowY: 'auto',
boxShadow: '0 4px 6px rgba(0, 0, 0, 0.1)'
}}>
Copy link

Copilot AI Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modal overlay lacks ARIA roles (e.g., role="dialog", aria-modal="true") and focus management; consider using an accessible modal component or enhancing keyboard and screen-reader support.

Suggested change
<div className="modal-overlay" onClick={closeModal} style={{
position: 'fixed',
top: 0,
left: 0,
right: 0,
bottom: 0,
backgroundColor: 'rgba(0, 0, 0, 0.5)',
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
zIndex: 1000
}}>
<div className="modal-content" onClick={(e) => e.stopPropagation()} style={{
backgroundColor: 'white',
padding: '2rem',
borderRadius: '8px',
maxWidth: '600px',
width: '90%',
maxHeight: '80vh',
overflowY: 'auto',
boxShadow: '0 4px 6px rgba(0, 0, 0, 0.1)'
}}>
<div
className="modal-overlay"
onClick={closeModal}
style={{
position: 'fixed',
top: 0,
left: 0,
right: 0,
bottom: 0,
backgroundColor: 'rgba(0, 0, 0, 0.5)',
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
zIndex: 1000
}}
>
<div
className="modal-content"
role="dialog"
aria-modal="true"
aria-labelledby="modal-title"
tabIndex="-1"
ref={modalRef}
onClick={(e) => e.stopPropagation()}
style={{
backgroundColor: 'white',
padding: '2rem',
borderRadius: '8px',
maxWidth: '600px',
width: '90%',
maxHeight: '80vh',
overflowY: 'auto',
boxShadow: '0 4px 6px rgba(0, 0, 0, 0.1)'
}}
>

Copilot uses AI. Check for mistakes.
@DaanHoogland DaanHoogland merged commit 95f9e01 into apache:staging-site Jul 2, 2025
3 checks passed
@DaanHoogland DaanHoogland deleted the update-integrations-page branch July 2, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants