vmware: volume utilisation is always zero

[yadvr]

• This fixes issues of virtual size to be twice in case the disk is a linked-clone root disk. The virtual size of root disk (first in chain) must be used.
• Fixes to report the physical size for a volume whose stat is being collected

After the fix utilisation is seen as below:

Logs also show valid values like:

2020-07-28 12:17:09,296 DEBUG [c.c.h.v.m.DatastoreMO] (DirectAgent-38:ctx-1a415fb5 10.10.4.235, cmd: GetVolumeStatsCommand) (logid:7c3f9cb8) File found = ROOT-3.vmdk, size=157134848
2020-07-28 12:17:09,471 DEBUG [c.c.h.v.m.DatastoreMO] (DirectAgent-38:ctx-1a415fb5 10.10.4.235, cmd: GetVolumeStatsCommand) (logid:7c3f9cb8) File found = b86db0909f7236d7acb343b0572bca65.vmdk, size=1201016832
2020-07-28 12:17:09,656 DEBUG [c.c.h.v.m.DatastoreMO] (DirectAgent-38:ctx-1a415fb5 10.10.4.235, cmd: GetVolumeStatsCommand) (logid:7c3f9cb8) File found = 2aee4824309444cba11c0508f33181ad.vmdk, size=0
2020-07-28 12:17:09,831 DEBUG [c.c.h.v.m.DatastoreMO] (DirectAgent-38:ctx-1a415fb5 10.10.4.235, cmd: GetVolumeStatsCommand) (logid:7c3f9cb8) File found = ROOT-4.vmdk, size=11329536
2020-07-28 12:17:10,040 DEBUG [c.c.h.v.m.DatastoreMO] (DirectAgent-38:ctx-1a415fb5 10.10.4.235, cmd: GetVolumeStatsCommand) (logid:7c3f9cb8) File found = 970775ec1cf233c08d6a3f0aaac9bec6.vmdk, size=1023160320

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1615

[yadvr]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[Spaceman1984]

@rhtyd I had a look at this, the physical size is reflecting correctly, but that utilization field is a bit strange on the front end, seems like the value should be multiplied by 100?

[blueorangutan]

Trillian test result (tid-2227)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44247 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4225-t2227-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	Error	1807.30	test_kubernetes_supported_versions.py
ContextSuite context=Test01DeployVM>:setup	Error	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	Error	0.00	test_vm_life_cycle.py

[yadvr]

@Spaceman1984 historically the volume utilisation has been a ratio of physical size by virtual size. But it makes sense to show it as a more human readable percentage. Fixed it cc @borisstoyanov

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1624

[borisstoyanov]

@blueorangutan test

[blueorangutan]

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[borisstoyanov]

LGTM

[blueorangutan]

Trillian test result (tid-2239)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46269 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4225-t2239-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_deploy_and_upgrade_kubernetes_cluster	Failure	1220.11	test_kubernetes_clusters.py

[DaanHoogland]

code makes sense but i have no idea on the consequences and accuracy, So I'm trusting @borisstoyanov 's assement in that respect.