Removed check on SSLEngine client mode

[Spaceman1984]

Description

The SSL engine defaults to "Server mode" when doing handshaking. This PR removes the check on the mode which was causing tests to fail.

This behavior was changed in OpenJDK 11.0.8

JDK-8245077: Default SSLEngine Created in Server Role
=====================================================
In JDK 11 and later, `javax.net.ssl.SSLEngine` by default used client
mode when handshaking.  As a result, the set of default enabled
protocols may differ to what is expected. `SSLEngine` would usually be
used in server mode. From this JDK release onwards, `SSLEngine` will
default to server mode. The
`javax.net.ssl.SSLEngine.setUseClientMode(boolean mode)` method may be
used to configure the mode.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This was tested by building Cloudstack and allowing the tests to run.

[Spaceman1984]

@GabrielBrascher I have created the pull request for 4.14 because this is JDK 11 specific, it will go to master as well.

[Spaceman1984]

@blueorangutan package

[blueorangutan]

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1616

[Spaceman1984]

@blueorangutan test

[blueorangutan]

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GabrielBrascher]

Code LGTM.

[RodrigoDLopez]

Code LGTM.

[blueorangutan]

Trillian test result (tid-2214)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37934 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4226-t2214-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=Test01DeployVM>:setup	Error	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	Error	0.00	test_vm_life_cycle.py
ContextSuite context=Test03SecuredVmMigration>:setup	Error	0.00	test_vm_life_cycle.py

[yadvr]

@Spaceman1984 can you check why the tests are failing, I'll kick tests again
@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[Spaceman1984]

I'll take a look why tests are failing @rhtyd

[yadvr]

Thanks @Spaceman1984 I've verified this fixes the immediate unit test failure and will merge it. If you find the failng test due to regression pl send a new PR.

[blueorangutan]

Trillian test result (tid-2217)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39959 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4226-t2217-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=Test01DeployVM>:setup	Error	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	Error	0.00	test_vm_life_cycle.py
ContextSuite context=Test03SecuredVmMigration>:setup	Error	0.00	test_vm_life_cycle.py
test_hostha_enable_ha_when_host_disabled	Error	2.56	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	Error	303.39	test_hostha_kvm.py