Skip to content

Display hypervisor type for VM snapshot#4275

Merged
yadvr merged 1 commit intoapache:4.14from
ravening:snapshot_hv_type
Aug 20, 2020
Merged

Display hypervisor type for VM snapshot#4275
yadvr merged 1 commit intoapache:4.14from
ravening:snapshot_hv_type

Conversation

@ravening
Copy link
Copy Markdown
Member

Description

The "hypervisor" field in listvmsnapshot response will
be used in primate to enable/disable creating a snapshot
from VM snapshot functionality.

Creating snapshot from VM snapshot will be enabled only if
the hypervisor is KVM

Types of changes

  • Enhancement (improves an existing feature and functionality)

Screenshots (if appropriate):

How Has This Been Tested?

Cloudmonkey output

(local) 🐵 > list vmsnapshot
{
  "count": 2,
  "vmSnapshot": [
    {
      "account": "admin",
      "created": "2020-08-18T11:12:11+0000",
      "current": true,
      "displayname": "i-2-5-VM_VS_20200818111211",
      "domain": "ROOT",
      "domainid": "f47-c10d-11ea-8715-063381",
      "hypervisor": "KVM",
      "id": "d34f9-df5a-4510-985a-e7f508ad",
      "name": "i-2-5-VM_VS_20200818111211",
      "state": "Ready",
      "tags": [],
      "type": "DiskAndMemory",
      "virtualmachineid": "52cfd-e8d6-4c85-a7e0-f603f151",
      "zoneid": "d0802-be7b-4345-8b55-1612c0b"
    },
    {
      "account": "admin",
      "created": "2020-08-17T15:48:08+0000",
      "current": true,
      "description": "second",
      "displayname": "second",
      "domain": "ROOT",
      "domainid": "f4702-c10d-11ea-8715-0623381",
      "hypervisor": "KVM",
      "id": "c953-0836-4d75-83a7-f805f8ad",
      "name": "i-2-8-VM_VS_20200817154808",
      "state": "Ready",
      "tags": [],
      "type": "DiskAndMemory",
      "virtualmachineid": "3c34-99d2-491c-b1a1-228ec87cb",
      "zoneid": "d0802-be7b-4345-8b55-1612fe0b"
    }
  ]
}

The "hypervisor" field in listvmsnapshot response will
be used in primate to enable/disable creating snapshot
from vm snapshot functionality.

Creating snpashot from vm snapshot will be enabled only if
hypervisor is KVM
@ravening
Copy link
Copy Markdown
Member Author

@rhtyd @davidjumani Please review

@yadvr yadvr added this to the 4.14.1.0 milestone Aug 19, 2020
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 19, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1787

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 19, 2020

(centos8 failure is ignorable as 4.14 does not support centos8 pkg support)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 19, 2020

Explicit smoketest is not needed as fix is presentation on API layer and we can merge as soon as Travis passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants