systemvm: fix proc.find in CsProcess.py#4413
Conversation
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
given good test results LGTM
| for i in CsHelper.execute("ps aux"): | ||
| items = len(self.search) | ||
| proc = re.split(r"\s+", i)[items*-1:] | ||
| proc = re.split(r"\s+", i)[10:] |
There was a problem hiding this comment.
given this is null based the return is now the full cli as returned by ps aux ; 👍
|
|
||
| def find_pid(self): | ||
| self.pid = [] | ||
| items = len(self.search) |
There was a problem hiding this comment.
maybe we should think about renaming search; it actually means to be the process/command name.
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2207 |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-3007)
|
svenvogel
added
component:ssvm
component:virtual-router
and removed
component:ssvm
labels
|
ping @rhtyd , not sure who else was involved in the predecessors of this one, but i think we can merge this one now. |
|
@davidjumani @borisstoyanov @andrijapanicsb @GabrielBrascher can we get more oks on this? |
|
@DaanHoogland good . |
|
@DaanHoogland this has been merged into 4.14. it needs to be merged into master as well |
6 participants
Description
This fixes the issues described in #4384 and #4386
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?