Add Python flake8 linting for W291 trailing whitespace with Super-Linter

[jbampton]

Description

Need to have standardized Python code.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

thanks @jbampton , I will try to merge this asap, Have you just removed trailing spaces or also looked at tab (especially component tests have that problem)?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2685

[jbampton]

Hey @DaanHoogland I only looked at trailing whitespace so far.

I was going to add a GitHub Action to run flake8 to test for W291 for trailing whitespace.

By adding this check it will mean it will stop regressions.

Yes I am interested in cleaning up tab problems in future and / or other Python linting problems.

https://flake8.pycqa.org/en/latest/
https://www.flake8rules.com/rules/W291.html

[DaanHoogland]

@blueorangutan test

[yadvr]

Ping @jbampton are you working on this, can you resolve conflicts? Thanks

[nvazquez]

Moving it to the next milestone

[nvazquez]

Hi @jbampton can you please fix the conflicts?

[jbampton]

@rohityadavcloud and @nvazquez I have removed the conflicts now

[jbampton]

@DaanHoogland I have included both spaces and tab in this update.

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2913

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3665)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31260 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4687-t3665-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[nvazquez]

Hi @DaanHoogland @weizhouapache @Pearl1594 could you please review? Smoke tests look good, no major changes besides removing spaces, I think it should be good to merge after approvals

[weizhouapache]

code lgtm

@jbampton can you tell how to configure the check on github ?

[DaanHoogland]

looks generally good but licenses need to be attended

[jbampton]

Hey @weizhouapache GitHub Actions don't run the first time they are added to a repo with a pull request.

So this PR will need to be merged and then new PRs will run this GitHub Action.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2967

[nvazquez]

@blueorangutan test matrix

[blueorangutan]

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3730)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28925 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4687-t3730-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py

[blueorangutan]

Trillian test result (tid-3728)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28840 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4687-t3728-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py

[blueorangutan]

Trillian test result (tid-3729)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28721 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4687-t3729-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py

[nvazquez]

Many thanks @jbampton PR merged, I can see the Github Action working for new PRs

[jbampton]

Thanks everyone 💯