Skip to content

Improve logs on RemoteAccessVpnManagerImpl #4960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 7 commits into from
Jun 10, 2021
Merged

Improve logs on RemoteAccessVpnManagerImpl #4960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
af63288
Extract code to method and test it
Apr 27, 2021
944d5d9
Few refactors
Apr 27, 2021
1e7bedd
Remove useless comments
Apr 27, 2021
e49fddf
Improve logs on RemoteAccessVpnManagerImpl
Apr 27, 2021
1b32662
Change toString to guarantee backward compatibility
Apr 30, 2021
7a19ff4
Remove copyright line in license header
GutoVeronezi May 5, 2021
633156d
Rename methods
May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/schema/src/main/java/com/cloud/network/VpnUserVO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public long getDomainId() {

@Override
public String toString() {
return new StringBuilder("VpnUser[").append(id).append("-").append(username).append("-").append(accountId).append("]").toString();
return String.format("VPN user {\"id\": %s, \"name\": \"%s\", \"uuid\": \"%s\", \"accountId\": %s}", id, username, uuid, accountId);
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion engine/schema/src/main/java/com/cloud/user/AccountVO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public long getAccountId() {

@Override
public String toString() {
return new StringBuilder("Acct[").append(uuid).append("-").append(accountName).append("]").toString();
return String.format("Acct[%s-%s] -- Account {\"id\": %s, \"name\": \"%s\", \"uuid\": \"%s\"}", uuid, accountName, id, accountName, uuid);
}

@Override
Expand Down
Loading