test: fix component test test_configdrive.py by weizhouapache · Pull Request #5528 · apache/cloudstack

weizhouapache · 2021-09-29T06:50:32Z

Description

This PR fixes some issues in test_configdrive.py and moves it from component test to smoke test.

(sleep 30s as vm crashes after migration in ubuntu 20.04)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

(sleep 30s as vm crashes after migration in ubuntu 20.04)

weizhouapache · 2021-09-29T06:51:03Z

@blueorangutan package

blueorangutan · 2021-09-29T06:52:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-29T07:17:13Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1436

weizhouapache · 2021-09-29T07:53:05Z

@blueorangutan test

blueorangutan · 2021-09-29T07:54:02Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-29T17:14:01Z

Trillian test result (tid-2235)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32221 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5528-t2235-kvm-centos7.zip
Smoke tests completed. 89 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
runTest	`Error`	0.00	test_configdrive.py
runTest	`Error`	0.00	test_configdrive.py

weizhouapache · 2021-09-29T19:56:25Z

@nvazquez moved to 4.16.1.0

sureshanaparti · 2021-12-20T06:27:50Z

@weizhouapache Is this PR ready for review?

weizhouapache · 2021-12-20T08:32:34Z

@weizhouapache Is this PR ready for review?

@sureshanaparti not yet. facing some issue with template registration in smoke test environments. I will look into it.

sureshanaparti · 2021-12-20T09:51:31Z

@weizhouapache Is this PR ready for review?

@sureshanaparti not yet. facing some issue with template registration in smoke test environments. I will look into it.

ok, thanks for the update @weizhouapache

weizhouapache · 2021-12-20T11:42:59Z

@blueorangutan package

blueorangutan · 2021-12-20T11:44:02Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-20T12:53:22Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1961

weizhouapache · 2021-12-20T12:58:35Z

@blueorangutan test

blueorangutan · 2021-12-20T12:59:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland

clgtm (small comment spello suggestion)

Co-authored-by: dahn <daan.hoogland@gmail.com>

blueorangutan · 2021-12-20T21:59:19Z

Trillian test result (tid-2688)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30919 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5528-t2688-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
runTest	`Error`	0.00	test_configdrive.py
runTest	`Error`	0.00	test_configdrive.py

sureshanaparti · 2021-12-21T04:55:59Z

Trillian test result (tid-2688) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30919 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5528-t2688-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
runTest Error 0.00 test_configdrive.py
runTest Error 0.00 test_configdrive.py

@weizhouapache can you check these test failures.

weizhouapache · 2021-12-21T08:13:07Z

@blueorangutan package

blueorangutan · 2021-12-21T09:11:59Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1977

blueorangutan · 2021-12-21T10:33:04Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1979

weizhouapache · 2021-12-21T10:45:39Z

@blueorangutan test suse15 kvm-suse15

blueorangutan · 2021-12-21T10:46:02Z

@weizhouapache a Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests

weizhouapache · 2021-12-21T12:02:45Z

@blueorangutan test

blueorangutan · 2021-12-21T12:03:04Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-12-21T22:43:34Z

Trillian test result (tid-2704)
Environment: kvm-suse15 (x2), Advanced Networking with Mgmt server s15
Total time taken: 41253 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5528-t2704-kvm-suse15.zip
Smoke tests completed. 90 look OK, 2 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	79.97	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	49.53	test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	305.99	test_hostha_kvm.py

blueorangutan · 2021-12-22T06:09:09Z

Trillian test result (tid-2705)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 63548 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5528-t2705-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_configdrive_isolated_network	`Error`	5213.49	test_configdrive.py
test_configdrive_shared_network	`Error`	1352.46	test_configdrive.py

DaanHoogland · 2021-12-22T08:19:20Z

code looks good to me but it still doesn't seem to work @weizhouapache . Do you have any idea yet?

Trillian test result (tid-2705) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 63548 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5528-t2705-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:
Test Result Time (s) Test File
test_configdrive_isolated_network Error 5213.49 test_configdrive.py
test_configdrive_shared_network Error 1352.46 test_configdrive.py

weizhouapache · 2021-12-22T08:22:40Z

code looks good to me but it still doesn't seem to work @weizhouapache . Do you have any idea yet?

Trillian test result (tid-2705) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 63548 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5528-t2705-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:
Test Result Time (s) Test File
test_configdrive_isolated_network Error 5213.49 test_configdrive.py
test_configdrive_shared_network Error 1352.46 test_configdrive.py

@DaanHoogland I am checking

weizhouapache · 2021-12-22T09:01:43Z

@blueorangutan test keepEnv

blueorangutan · 2021-12-22T09:02:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache · 2021-12-22T09:03:01Z

just run the test on a env with pr 5769, it looks good.

[root@pr5769-t2700-kvm-centos7-marvin ~]# cat /marvin//MarvinLogs//06MT81/results.txt 
Test Configdrive as provider for isolated Networks ... === TestName: test_configdrive_isolated_network | Status : SUCCESS ===
ok
Test Configdrive as provider for isolated Networks ... === TestName: test_configdrive_isolated_network_hypervisor_hostname_exposed | Status : SUCCESS ===
ok
Test Configdrive as provider for shared Networks ... === TestName: test_configdrive_shared_network | Status : SUCCESS ===
ok
Test Configdrive for VPC Networks ... === TestName: test_configdrive_vpc_network | Status : SUCCESS ===
ok
Test Configdrive for VPC Networks ... === TestName: test_configdrive_vpc_network_verify_metadata | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 5 tests in 6192.782s

OK

rekick the test

blueorangutan · 2021-12-22T19:54:10Z

Trillian test result (tid-2715)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37570 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5528-t2715-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2021-12-23T07:35:30Z

@sureshanaparti @DaanHoogland
test passed. this is ready for review.
However, I wonder if neccesary to move it to smoke test (run the tests in 103 minutes in my testing)

blueorangutan · 2021-12-23T17:56:33Z

Trillian test result (tid-2729)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36873 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5528-t2729-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

sureshanaparti

code LGTM

DaanHoogland · 2021-12-27T08:30:47Z

However, I wonder if neccesary to move it to smoke test (run the tests in 103 minutes in my testing)

Wei, can we extract a minimal set into a smoke test and leave the rest in components?

test: fix test_configdrive.py and move it to smoke test

72becdc

(sleep 30s as vm crashes after migration in ubuntu 20.04)

weizhouapache added this to the 4.16.0.0 milestone Sep 29, 2021

weizhouapache closed this Sep 29, 2021

weizhouapache reopened this Sep 29, 2021

weizhouapache modified the milestones: 4.16.0.0, 4.16.1.0 Sep 29, 2021

yadvr changed the base branch from main to 4.16 November 15, 2021 10:10

sureshanaparti assigned weizhouapache Dec 7, 2021

sureshanaparti requested a review from DaanHoogland December 20, 2021 09:51

DaanHoogland approved these changes Dec 20, 2021

View reviewed changes

Comment thread test/integration/smoke/test_configdrive.py Outdated

Update test/integration/smoke/test_configdrive.py

14388b3

Co-authored-by: dahn <daan.hoogland@gmail.com>

apache deleted a comment from blueorangutan Dec 21, 2021

DaanHoogland self-requested a review December 22, 2021 08:19

apache deleted a comment from blueorangutan Dec 23, 2021

weizhouapache marked this pull request as ready for review December 23, 2021 07:17

apache deleted a comment from blueorangutan Dec 23, 2021

sureshanaparti approved these changes Dec 24, 2021

View reviewed changes

Update apache#5528: move back to component test

f1da958

weizhouapache changed the title ~~test: fix test_configdrive.py and move it to smoke test~~ test: fix component test test_configdrive.py Dec 24, 2021

sureshanaparti self-requested a review December 24, 2021 07:44

sureshanaparti approved these changes Dec 24, 2021

View reviewed changes

yadvr approved these changes Dec 30, 2021

View reviewed changes

yadvr merged commit 4ba2ad5 into apache:4.16 Dec 30, 2021

weizhouapache deleted the 4.16-add-smoke-test-configdrive branch December 9, 2022 08:45

Conversation

weizhouapache commented Sep 29, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Sep 29, 2021

Uh oh!

blueorangutan commented Sep 29, 2021

Uh oh!

blueorangutan commented Sep 29, 2021

Uh oh!

weizhouapache commented Sep 29, 2021

Uh oh!

blueorangutan commented Sep 29, 2021

Uh oh!

blueorangutan commented Sep 29, 2021

Uh oh!

weizhouapache commented Sep 29, 2021

Uh oh!

sureshanaparti commented Dec 20, 2021

Uh oh!

weizhouapache commented Dec 20, 2021

Uh oh!

sureshanaparti commented Dec 20, 2021

Uh oh!

weizhouapache commented Dec 20, 2021

Uh oh!

blueorangutan commented Dec 20, 2021

Uh oh!

blueorangutan commented Dec 20, 2021

Uh oh!

weizhouapache commented Dec 20, 2021

Uh oh!

blueorangutan commented Dec 20, 2021

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

blueorangutan commented Dec 20, 2021

Uh oh!

sureshanaparti commented Dec 21, 2021

Uh oh!

weizhouapache commented Dec 21, 2021

Uh oh!

blueorangutan commented Dec 21, 2021

Uh oh!

blueorangutan commented Dec 21, 2021

Uh oh!

weizhouapache commented Dec 21, 2021

Uh oh!

blueorangutan commented Dec 21, 2021

Uh oh!

weizhouapache commented Dec 21, 2021

Uh oh!

blueorangutan commented Dec 21, 2021

Uh oh!

blueorangutan commented Dec 21, 2021

Uh oh!

blueorangutan commented Dec 22, 2021

Uh oh!

DaanHoogland commented Dec 22, 2021

Uh oh!

weizhouapache commented Dec 22, 2021

Uh oh!

weizhouapache commented Dec 22, 2021

Uh oh!

blueorangutan commented Dec 22, 2021

Uh oh!

weizhouapache commented Dec 22, 2021

Uh oh!

blueorangutan commented Dec 22, 2021

Uh oh!

weizhouapache commented Dec 23, 2021

Uh oh!