Skip to content

Adding placeholders for custom NSP vues#5620

Merged
sureshanaparti merged 3 commits intoapache:4.16from
shapeblue:nsp-labels
Jan 27, 2022
Merged

Adding placeholders for custom NSP vues#5620
sureshanaparti merged 3 commits intoapache:4.16from
shapeblue:nsp-labels

Conversation

@davidjumani
Copy link
Copy Markdown
Contributor

Description

Adds placeholder text for NSPs with custom vues

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

TODO

@yadvr yadvr changed the base branch from main to 4.16 November 15, 2021 10:28
@yadvr yadvr added this to the 4.16.1.0 milestone Nov 15, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 18, 2021

ping @davidjumani is this ready?

@davidjumani
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@davidjumani davidjumani marked this pull request as ready for review November 19, 2021 06:48
@blueorangutan
Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@davidjumani davidjumani requested a review from utchoang November 19, 2021 06:51
@blueorangutan
Copy link
Copy Markdown

UI build: ✖️
(SL-JID-842)

Comment thread ui/src/views/infra/network/providers/AddSrxFirewall.vue Outdated
@sureshanaparti
Copy link
Copy Markdown
Contributor

Hi @davidjumani, Can you address the outstanding comments.

@sureshanaparti
Copy link
Copy Markdown
Contributor

ping @davidjumani please address the outstanding comments. thanks.

@davidjumani
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @davidjumani

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5620 (SL-JID-1073)

@sureshanaparti
Copy link
Copy Markdown
Contributor

Verified the placeholder descriptions from the API params.

@davidjumani Can you update the description for the below param in addNetscalerLoadBalancer API.

@Parameter(name = ApiConstants.GSLB_PROVIDER_PRIVATE_IP, type = CommandType.STRING, required = false, description = "public IP of the site")

@davidjumani
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2338

@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✖️ suse15. SL-JID 2345

@sureshanaparti
Copy link
Copy Markdown
Contributor

UI changes and addNetscalerLoadBalancer API param description change. Smoke tests not needed.

@sureshanaparti sureshanaparti merged commit 6fa8538 into apache:4.16 Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants