Skip to content

UI: Add footer text option for login screen#5628

Merged
yadvr merged 7 commits intoapache:4.16from
EWERK-DIGITAL:feature/login-footer-text
Dec 30, 2021
Merged

UI: Add footer text option for login screen#5628
yadvr merged 7 commits intoapache:4.16from
EWERK-DIGITAL:feature/login-footer-text

Conversation

@utchoang
Copy link
Copy Markdown

Description

This PR fixes #5622

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@utchoang utchoang changed the title add footer text option for login screen UI: Add footer text option for login screen Oct 26, 2021
@utchoang
Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5628 (SL-JID-785)

@yadvr yadvr requested review from PaulAngus, shwstppr and yadvr October 27, 2021 08:34
Comment thread ui/public/config.json Outdated
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works but somewhat confusing property name. We already have a footer property in the config file.
Good thing we have a doc PR

@utchoang
Copy link
Copy Markdown
Author

utchoang commented Nov 1, 2021

@blueorangutan ui

@utchoang utchoang requested a review from shwstppr November 1, 2021 01:05
Comment thread ui/public/config.json Outdated
Comment thread ui/public/config.json Outdated
@yadvr yadvr changed the base branch from main to 4.16 November 15, 2021 10:12
@yadvr yadvr added this to the 4.16.1.0 milestone Nov 15, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 18, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✖️
(SL-JID-836)

@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5628 (SL-JID-910)

@yadvr yadvr merged commit 5eccbc9 into apache:4.16 Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Add Footer text option for login screen

6 participants