Skip to content

simplify code using optional chaining in multiple views#5630

Merged
nvazquez merged 2 commits intoapache:mainfrom
Damans227:2_issue_4956
Feb 6, 2022
Merged

simplify code using optional chaining in multiple views#5630
nvazquez merged 2 commits intoapache:mainfrom
Damans227:2_issue_4956

Conversation

@Damans227
Copy link
Copy Markdown
Collaborator

Description

This PR is related to issue: ui: Simplify code #4956

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
Copy link
Copy Markdown

utchoang commented Nov 8, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✖️
(SL-JID-811)

Comment thread ui/src/views/network/CreateL2NetworkForm.vue Outdated
Comment thread ui/src/views/network/CreateL2NetworkForm.vue Outdated
@utchoang
Copy link
Copy Markdown

@blueorangutan ui

1 similar comment
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 18, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidjumani
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5630 (SL-JID-1072)

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM

@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented Feb 6, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✖️
(SL-JID-1096)

@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented Feb 6, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5630 (SL-JID-1097)

@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented Feb 6, 2022

Merging based on approvals

@nvazquez nvazquez merged commit 649be0d into apache:main Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants