assume a property is one when it isn't a number#5647
assume a property is one when it isn't a number#5647sureshanaparti merged 1 commit intoapache:4.16from
Conversation
| Element disk = (Element)diskElements.item(i); | ||
| long diskSize = Long.parseLong(disk.getAttribute("ovf:capacity")); | ||
| String diskSizeValue = disk.getAttribute("ovf:capacity"); | ||
| long diskSize = 1; |
There was a problem hiding this comment.
not sure here if we should 'some' or 0 (zero)
| // TODO parse the property to get any value can not be done at registration time | ||
| // and will have to be done at deploytime, so for orchestration purposes | ||
| // we now assume, a value of one |
There was a problem hiding this comment.
more like a design brainstorm than a TODO
There was a problem hiding this comment.
@DaanHoogland any specific reason for completely not supporting those kinds of templates instead of assuming the size to be 1 ? I think this approach will have some effect on the usage records of the volume also.
There was a problem hiding this comment.
@harikrishna-patnala this is only the template and there will be only a "real" disksize on/after deployment. This will only fix registration btw, and assumes deployment is going on as usual, probably for bad reason.
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1649 |
|
@blueorangutan test centos7 vmware-70u1 |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests |
|
Trillian test result (tid-2510)
|
5 participants
Description
This PR handles an OVA that uses a property replacement for a disksize value
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?