Skip to content

UI - Deploy VM with params from the template, iso, network pages#5653

Merged
sureshanaparti merged 4 commits intoapache:4.16from
EWERK-DIGITAL:feature/deploy-vm-with-params
Jan 13, 2022
Merged

UI - Deploy VM with params from the template, iso, network pages#5653
sureshanaparti merged 4 commits intoapache:4.16from
EWERK-DIGITAL:feature/deploy-vm-with-params

Conversation

@utchoang
Copy link
Copy Markdown

@utchoang utchoang commented Nov 2, 2021

Description

This PR fixes #5639

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
Copy link
Copy Markdown
Author

utchoang commented Nov 2, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 2, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 2, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-802)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 2, 2021

I think the specific parameter should be passed to the url and be picked up by the form.

@utchoang
Copy link
Copy Markdown
Author

utchoang commented Nov 3, 2021

@rhtyd Will now pass the template id, network id on the URL, and will auto-select it on the form.

@yadvr yadvr changed the base branch from main to 4.16 November 15, 2021 10:15
@yadvr yadvr added this to the 4.16.1.0 milestone Nov 15, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 18, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 18, 2021

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@yadvr yadvr requested review from Pearl1594 and shwstppr and removed request for shwstppr November 18, 2021 08:23
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 18, 2021

UI build: ✖️
(SL-JID-835)

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Dec 16, 2021

@blueorangutan ui

yadvr
yadvr reviewed Dec 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs testing

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Dec 30, 2021

@blueorangutan ui

1 similar comment
@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jan 3, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 3, 2022

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 3, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-967)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 8, 2022

@blueorangutan ui

1 similar comment
@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jan 10, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 10, 2022

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 10, 2022

UI build: ✖️
(SL-JID-992)

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jan 10, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 10, 2022

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 10, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-996)

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jan 10, 2022

Verified deploy VM from template and network. LGTM.

weizhouapache
weizhouapache approved these changes Jan 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok. thanks for fixing.

@sureshanaparti sureshanaparti merged commit 001f421 into apache:4.16 Jan 13, 2022
@sureshanaparti sureshanaparti mentioned this pull request Jan 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr left review comments

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@shwstppr shwstppr Awaiting requested review from shwstppr

@davidjumani davidjumani Awaiting requested review from davidjumani

Assignees

No one assigned

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.

[UI] feature request: deploy vm with param from previous page

6 participants

@utchoang @blueorangutan @yadvr @sureshanaparti @shwstppr @weizhouapache