Skip to content

UI - Cancel all requests api, async jobs when user logs out#5663

Merged
sureshanaparti merged 3 commits intoapache:4.16from
EWERK-DIGITAL:feature/logout-cancel-request
Jan 13, 2022
Merged

UI - Cancel all requests api, async jobs when user logs out#5663
sureshanaparti merged 3 commits intoapache:4.16from
EWERK-DIGITAL:feature/logout-cancel-request

Conversation

@utchoang
Copy link
Copy Markdown

@utchoang utchoang commented Nov 4, 2021

Description

This PR fixes #5652

When the user performs tasks related to API requests or runs async jobs, as soon as the user logs out, the API requests and async jobs will be canceled immediately.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@PaulAngus
Copy link
Copy Markdown
Member

@utchoang Can you add some description of what you're actually trying to achieve here please.

The title reads like this - if a user sets off an async job like a volume snapshot, and then logs out, that async job (volume snapshot) would then be canceled.

@PaulAngus
Copy link
Copy Markdown
Member

@utchoang Can you add some description of what you're actually trying to achieve here please.

The title reads like this - if a user sets off an async job like a volume snapshot, and then logs out, that async job (volume snapshot) would then be canceled.

is the thumbsup to say 'yes, if a user logs out when a snapshot is taking place, then the job is cancelled' ?

@yadvr yadvr changed the base branch from main to 4.16 November 15, 2021 10:15
@yadvr yadvr added this to the 4.16.1.0 milestone Nov 15, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 18, 2021

No, it won't cancel the job - just UI will cancelling its internal polls for async job results.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 18, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM needs testing

@blueorangutan
Copy link
Copy Markdown

UI build: ✖️
(SL-JID-834)

@shwstppr
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5663 (SL-JID-851)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Dec 30, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5663 (SL-JID-952)

@yadvr yadvr requested a review from sureshanaparti January 8, 2022 03:30
@sureshanaparti sureshanaparti self-assigned this Jan 12, 2022
@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jan 13, 2022

Hi @utchoang I deployed few VMs from UI and logged out. Noticed the job progress still displayed after logout. Please check.

@utchoang
Copy link
Copy Markdown
Author

@sureshanaparti How did you create that multiple requests?

@utchoang
Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5663 (SL-JID-1009)

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti How did you create that multiple requests?

I've deployed these VMs from 'Add Instance' form in the UI.

@sureshanaparti
Copy link
Copy Markdown
Contributor

Verified. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

On logout purge async job list in UI

6 participants