Allow large IPSec key (PSK) when creating VPN#5668
Conversation
|
@blueorangutan package |
|
@GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1689 |
3e05ede to
49fc801
Compare
|
LGTM |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 1708 |
e6d4607 to
67d334c
Compare
GabrielBrascher
left a comment
There was a problem hiding this comment.
Code LGTM.
Thanks, @joseflauzino!
|
@blueorangutan package |
|
@GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1720 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-2558)
|
… to 4.17 (apache#5668) Co-authored-by: José Flauzino <jose@scclouds.com.br>
Description
The global parameter
remote.access.vpn.psk.lengthsets the length of the IPSec key (a PSK). Theipsec_pskfield (which is a varchar(256) in theremote_access_vpntable) stores the PSK in encrypted form - it has an@Encryptannotation. When the value defined inremote.access.vpn.psk.lengthgenerates a PSK that, when encrypted, has more than 256 characters, ACS throws a database exception when trying to persist the data, preventing the creation of the VPN.This PR changes the
ipsec_pskfield from varchar(256) to text in order to allow the creation of large PSKs.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
How Has This Been Tested?
In a local lab, I performed the following steps:
ipsec_pskfield fromvarchar(256)to the typetext;remote.access.vpn.psk.lengthto 224 (which generates an encrypted PSK with 320 characters - more than the previous limit, 256);