Skip to content

server bug fix: remove network details when network is removed #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weizhouapache merged 2 commits into from
Nov 25, 2021
Merged

server bug fix: remove network details when network is removed #5675

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a2523
server bug fix: remove network details when network is removed
weizhouapache Nov 10, 2021
0a07a07
Update #5675: remove comment
weizhouapache Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...tration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3116,6 +3116,8 @@ public void doInTransactionWithoutResult(final TransactionStatus status) {
if (networkAccount != null) {
_networkAccountDao.remove(networkAccount.getId());
}

networkDetailsDao.removeDetails(networkFinal.getId());
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti Nov 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The foreign key should serve the purpose here. But, when a network is destroyed, the removed date is set, and the record is not removed from the table (to keep/track the history at later stage when needed). The same is the case with most of the resources, where the foreign key is set with 'ON DELETE CASCADE' but unused. May be, a cleanup (enabled/disabled) for all such removed entires from the DB, have to be introduced at regular intervals (that can be set using global config).

CONSTRAINT `fk_network_details__network_id` FOREIGN KEY `fk_network_details__network_id`(`network_id`) REFERENCES `networks`(`id`) ON DELETE CASCADE

Copy link
Copy Markdown
Member Author

@weizhouapache weizhouapache Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti
yes, you are absolutely right. ON DELETE CASCADE does not work as expected because cloudstack updates removed field instead deleting the record from DB.

}

final NetworkOffering ntwkOff = _entityMgr.findById(NetworkOffering.class, networkFinal.getNetworkOfferingId());
Expand Down Expand Up @@ -4403,4 +4405,4 @@ public ConfigKey<?>[] getConfigKeys() {
GuestDomainSuffix, NetworkThrottlingRate, MinVRVersion,
PromiscuousMode, MacAddressChanges, ForgedTransmits, MacLearning, RollingRestartEnabled};
}
}
}