Skip to content

UI: Fixes incorrect auto-select in Add network to VM#5693

Merged
yadvr merged 1 commit intoapache:4.16from
EWERK-DIGITAL:feature/fix-autoselect-network-nic
Nov 18, 2021
Merged

UI: Fixes incorrect auto-select in Add network to VM#5693
yadvr merged 1 commit intoapache:4.16from
EWERK-DIGITAL:feature/fix-autoselect-network-nic

Conversation

@utchoang
Copy link
Copy Markdown

@utchoang utchoang commented Nov 17, 2021

Description

This PR fixes #5691
After adding a NIC to the virtual machine, continue to add the NIC by opening the "Add network to virtual machine" form again, the network field auto-selects wrong.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@shwstppr
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5693 (SL-JID-831)

@yadvr yadvr added this to the 4.16.1.0 milestone Nov 17, 2021
Copy link
Copy Markdown
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr merged commit 0684aff into apache:4.16 Nov 18, 2021
@utchoang utchoang deleted the feature/fix-autoselect-network-nic branch November 18, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants