remove superfluent counter and fix log message by DaanHoogland · Pull Request #6313 · apache/cloudstack

DaanHoogland · 2022-04-25T08:03:51Z

Description

This PR fixes (some of) the excessive log sizes caused by #5588

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

acs-robot · 2022-04-25T08:46:53Z

PR Coverage Report

CLASS	INSTRUCTION MISSED	INSTRUCTION COVERED	BRANCH MISSED	BRANCH COVERED	LINE MISSED	LINE COVERED
ApiSessionListener	119	0	2	0	28	0

nvazquez · 2022-04-25T10:33:18Z

@blueorangutan package

nvazquez · 2022-04-25T10:53:00Z

@blueorangutan package

blueorangutan · 2022-04-25T10:54:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

blueorangutan · 2022-04-25T11:30:52Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3299

nvazquez · 2022-04-25T11:34:56Z

@blueorangutan package

blueorangutan · 2022-04-25T11:36:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

acs-robot · 2022-04-25T11:51:13Z

PR Coverage Report

CLASS	INSTRUCTION MISSED	INSTRUCTION COVERED	BRANCH MISSED	BRANCH COVERED	LINE MISSED	LINE COVERED
ApiSessionListener	117	0	2	0	28	0

blueorangutan · 2022-04-25T12:16:57Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3300

nvazquez · 2022-04-25T12:17:28Z

@blueorangutan test

blueorangutan · 2022-04-25T12:18:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-04-26T02:21:40Z

Trillian test result (tid-4033)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49240 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6313-t4033-kvm-centos7.zip
Smoke tests completed. 64 look OK, 21 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.58	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.10	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.18	test_primary_storage.py
test_02_create_template_with_checksum_sha1	`Error`	65.45	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.45	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.46	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.45	test_templates.py
test_list_vms_metrics	`Error`	0.00	test_metrics_api.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
test_01_volume_usage	`Error`	186.00	test_usage.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestInternalLb>:setup	`Error`	0.00	test_internal_lb.py
test_01_1_create_iso_with_checksum_sha1_negative	`Error`	66.44	test_iso.py
test_01_create_iso_with_checksum_sha1	`Error`	66.44	test_iso.py
test_01_create_iso_with_checksum_sha1	`Error`	66.44	test_iso.py
test_02_1_create_iso_with_checksum_sha256_negative	`Error`	66.42	test_iso.py
test_02_create_iso_with_checksum_sha256	`Error`	66.41	test_iso.py
test_02_create_iso_with_checksum_sha256	`Error`	66.41	test_iso.py
test_03_1_create_iso_with_checksum_md5_negative	`Error`	66.43	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	66.43	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	66.43	test_iso.py
test_04_create_iso_with_no_checksum	`Error`	66.44	test_iso.py
test_04_create_iso_with_no_checksum	`Error`	66.44	test_iso.py
test_01_create_iso	`Failure`	1513.96	test_iso.py
ContextSuite context=TestISO>:setup	`Error`	3026.85	test_iso.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	0.17	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	0.16	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	1.30	test_routers_network_ops.py
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version	`Error`	1802.11	test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_delete_account	`Error`	1.74	test_network.py
test_delete_network_while_vm_on_it	`Error`	1.12	test_network.py
test_deploy_vm_l2network	`Error`	1.13	test_network.py
test_l2network_restart	`Error`	2.26	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	3.44	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	3.56	test_network.py
test_reboot_router	`Failure`	0.05	test_network.py
test_releaseIP	`Error`	1.69	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	1.75	test_network.py
ContextSuite context=TestNetworkACL>:setup	`Error`	0.00	test_network_acl.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.12	test_service_offerings.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	302.70	test_hostha_kvm.py

This reverts commit a9bbcf8.

remove superfluent counter and fix log message

235e2d2

DaanHoogland added this to the 4.17.0.0 milestone Apr 25, 2022

DaanHoogland requested review from Pearl1594 and nvazquez April 25, 2022 08:03

Pearl1594 reviewed Apr 25, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/api/ApiSessionListener.java Outdated

Comment thread server/src/main/java/com/cloud/api/ApiSessionListener.java Outdated

yadvr approved these changes Apr 25, 2022

View reviewed changes

nvazquez approved these changes Apr 25, 2022

View reviewed changes

Apply suggestions from code review

9cb3fda

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

Pearl1594 approved these changes Apr 25, 2022

View reviewed changes

nvazquez added type:enhancement type:cleanup labels Apr 25, 2022

nvazquez approved these changes Apr 26, 2022

View reviewed changes

nvazquez merged commit a9bbcf8 into apache:main Apr 26, 2022

DaanHoogland added a commit to shapeblue/cloudstack that referenced this pull request May 16, 2022

Revert "remove superfluent counter and fix log message (apache#6313)"

ec10ef0

This reverts commit a9bbcf8.

Conversation

DaanHoogland commented Apr 25, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Uh oh!

Uh oh!

acs-robot commented Apr 25, 2022

PR Coverage Report

Uh oh!

nvazquez commented Apr 25, 2022

Uh oh!

nvazquez commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

nvazquez commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

acs-robot commented Apr 25, 2022

PR Coverage Report

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

nvazquez commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants