Skip to content

UI: Fix new network service provider dialog#6583

Merged
shwstppr merged 1 commit intoapache:4.17from
shapeblue:fixinputformreactive
Jul 29, 2022
Merged

UI: Fix new network service provider dialog#6583
shwstppr merged 1 commit intoapache:4.17from
shapeblue:fixinputformreactive

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue on the input fields for new network service providers, could not enter data on them.

Screen Shot 2022-07-28 at 19 53 04

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Go to Zone -> Physical network -> Network providers -> Pick a provider and try to add a new provider

@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6583 (SL-JID-2024)

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified by entering the values and validating the fired API.
LGTM

Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shwstppr shwstppr merged commit 82e7e94 into apache:4.17 Jul 29, 2022
neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Aug 6, 2022
@nvazquez nvazquez deleted the fixinputformreactive branch January 30, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants