Skip to content

vpc,network: fix createLoadBalancer access on user network#6591

Merged
yadvr merged 2 commits intoapache:4.17from
shapeblue:fix-vpctier-lb-domadm
Aug 9, 2022
Merged

vpc,network: fix createLoadBalancer access on user network#6591
yadvr merged 2 commits intoapache:4.17from
shapeblue:fix-vpctier-lb-domadm

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Jul 30, 2022 •
edited
Loading

Description

While checking network access for creating load-balancer use AccessType.OperateEntry
Refactor variable name in NetworkModelImpl::checkNetworkPermissions

Fixes: #6590

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@shwstppr
vpc,network: fix createLoadBalancer access on user network
b7094ff 
Fixes: apache#6590

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@acs-robot
Copy link
Copy Markdown

acs-robot commented Jul 30, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 30, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 30, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6591 (SL-JID-2036)

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jul 30, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 30, 2022

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 30, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3861

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Jul 30, 2022

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 30, 2022

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 31, 2022

Trillian test result (tid-4578)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43123 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6591-t4578-vmware-67u3.zip
Smoke tests completed. 100 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@shwstppr shwstppr marked this pull request as ready for review July 31, 2022 11:12
@shwstppr shwstppr linked an issue Jul 31, 2022 that may be closed by this pull request
Permission Denied on Domain Controller For Internal LB #6590
Closed
@shwstppr shwstppr closed this Jul 31, 2022
@shwstppr shwstppr reopened this Jul 31, 2022
@shwstppr shwstppr requested a review from weizhouapache August 1, 2022 10:55
weizhouapache
weizhouapache approved these changes Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

it looks this issue has existed for many years. should we fix it in older versions as well ?

yadvr
yadvr reviewed Aug 3, 2022
View reviewed changes
Comment thread server/src/main/java/com/cloud/network/NetworkModelImpl.java

@Override
public void checkNetworkPermissions(Account owner, Network network) {
public void checkNetworkPermissions(Account caller, Network network) {
Copy link
Copy Markdown
Member

@yadvr yadvr Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we explore if a unit test is written

Copy link
Copy Markdown
Contributor Author

@shwstppr shwstppr Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some unit tests

@shwstppr shwstppr added this to the 4.17.1.0 milestone Aug 5, 2022
@shwstppr
add some tests
3934b85 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@acs-robot
Copy link
Copy Markdown

acs-robot commented Aug 5, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 5, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 5, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6591 (SL-JID-2084)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 5, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 5, 2022

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 8, 2022

Packaging result: ✔️ el7 ✖️ el8 ✔️ debian ✔️ suse15. SL-JID 3920

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 8, 2022

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 8, 2022

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 8, 2022

Trillian test result (tid-4635)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41100 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6591-t4635-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 805.78 test_kubernetes_clusters.py

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 9, 2022

@weizhouapache do you think this should go into 4.16 or earlier?

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 9, 2022

No I think, 4.17 + makes sense.

@yadvr yadvr merged commit 6842583 into apache:4.17 Aug 9, 2022
@yadvr yadvr mentioned this pull request Aug 9, 2022
Closed
neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Sep 5, 2022
@shwstppr @neogismm
vpc,network: fix createLoadBalancer access on user network (apache#6591)
6350adf 
While checking network access for creating load-balancer use AccessType.OperateEntry
Refactor variable name in NetworkModelImpl::checkNetworkPermissions

Fixes: apache#6590

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

component:networking

Projects

None yet

Milestone

4.17.1.0

Development

Successfully merging this pull request may close these issues.

Permission Denied on Domain Controller For Internal LB

5 participants

@shwstppr @acs-robot @blueorangutan @weizhouapache @yadvr