Skip to content

UI: Fixes notification error can't close when exit config limit tab#6607

Merged
shwstppr merged 2 commits intoapache:4.17from
EWERK-DIGITAL:feature/fix-config-limit-error
Aug 3, 2022
Merged

UI: Fixes notification error can't close when exit config limit tab#6607
shwstppr merged 2 commits intoapache:4.17from
EWERK-DIGITAL:feature/fix-config-limit-error

Conversation

@utchoang
Copy link
Copy Markdown

@utchoang utchoang commented Aug 3, 2022

Description

This PR fixes #6602

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6607 (SL-JID-2066)

Copy link
Copy Markdown
Contributor

@slavkap slavkap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @utchoang! LGTM manually tested

@shwstppr shwstppr added this to the 4.17.1.0 milestone Aug 3, 2022
@shwstppr shwstppr self-requested a review August 3, 2022 08:31
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utchoang this introduces another issue. Now when you navigate between different domains resource count is not being updated

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Aug 3, 2022

@utchoang removing deep: true fixes things for me

@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6607 (SL-JID-2067)

@shwstppr shwstppr requested a review from slavkap August 3, 2022 09:26
@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Aug 3, 2022

@slavkap can you please check once again now

Copy link
Copy Markdown
Contributor

@slavkap slavkap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shwstppr shwstppr linked an issue Aug 3, 2022 that may be closed by this pull request
@shwstppr shwstppr merged commit 06ff472 into apache:4.17 Aug 3, 2022
neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Aug 6, 2022
…pache#6607)

* fixed an error that generated incorrect messages when accessing the config limit tab

* removed deep:true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Notification error is shown and cannot be closed

5 participants