Allow creating atmost 1 physical network with null tag by soreana · Pull Request #6781 · apache/cloudstack

soreana · 2022-09-28T15:17:51Z

Description

This pr is a follow up to the #3780 quoted the following from the pr:

Currently, we can create multiple physical networks in the same traffic types with null tags. This feature will ensure that we can create at most 1 physical network in the same traffic type with a null tag.
Every physical network should be associated with a tag so that when we create a new shared network, using the tags we can match the shared network with the physical network

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

Please refer to the old pr at: #3780

DaanHoogland · 2022-09-28T15:40:37Z

@blueorangutan package

blueorangutan · 2022-09-28T15:41:02Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2022-09-28T16:13:44Z

Codecov Report

Merging #6781 (d6edec9) into main (69e158d) will increase coverage by 1.31%.
The diff coverage is 4.93%.

@@             Coverage Diff              @@
##               main    #6781      +/-   ##
============================================
+ Coverage     10.60%   11.92%   +1.31%     
- Complexity     6854     8228    +1374     
============================================
  Files          2466     2496      +30     
  Lines        244615   275545   +30930     
  Branches      38274    50240   +11966     
============================================
+ Hits          25938    32847    +6909     
- Misses       215395   238462   +23067     
- Partials       3282     4236     +954

Impacted Files	Coverage Δ
...ain/java/com/cloud/network/dao/NetworkDaoImpl.java	`3.21% <0.00%> (ø)`
.../main/java/com/cloud/network/NetworkModelImpl.java	`13.35% <0.00%> (+2.36%)`	⬆️
...ain/java/com/cloud/network/NetworkServiceImpl.java	`13.16% <0.00%> (+3.34%)`	⬆️
.../cloud/configuration/ConfigurationManagerImpl.java	`14.74% <16.66%> (+3.51%)`	⬆️
...org/apache/cloudstack/quota/vo/QuotaBalanceVO.java	`28.20% <0.00%> (-17.95%)`	⬇️
...che/cloudstack/api/command/QuotaTariffListCmd.java	`58.97% <0.00%> (-12.46%)`	⬇️
...e/cloudstack/api/command/QuotaTariffUpdateCmd.java	`40.00% <0.00%> (-12.39%)`	⬇️
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java	`36.98% <0.00%> (-9.69%)`	⬇️
...in/java/com/cloud/offerings/NetworkOfferingVO.java	`34.91% <0.00%> (-7.84%)`	⬇️
.../com/cloud/api/query/vo/NetworkOfferingJoinVO.java	`17.64% <0.00%> (-6.41%)`	⬇️
... and 286 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

blueorangutan · 2022-09-28T16:56:48Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4304

DaanHoogland · 2022-09-29T06:50:12Z

@blueorangutan test

blueorangutan · 2022-09-29T06:51:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2022-09-29T06:51:32Z

@soreana did you apply any of the comments from #3780?

soreana · 2022-09-29T08:47:51Z

@soreana did you apply any of the comments from #3780?

@DaanHoogland Sure, I'm on it.

acs-robot · 2022-09-29T09:58:01Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-09-29T09:59:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

soreana · 2022-09-29T10:03:52Z

@DaanHoogland I've changed the integration test regarding your comments. Let me know if you have any concerns.

blueorangutan · 2022-09-29T10:10:23Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6781 (SL-JID-2437)

DaanHoogland · 2022-09-29T13:36:42Z

@soreana in the original PR it was asked to put this behind a setting by @andrijapanicsb . I do not see that implemented here yet. Are you planning to do that?

blueorangutan · 2022-09-29T19:41:46Z

Trillian test result (tid-5040)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44926 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6781-t5040-kvm-centos7.zip
Smoke tests completed. 101 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	611.00	test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	466.08	test_vpc_redundant.py

soreana · 2022-10-10T09:51:27Z

@DaanHoogland Can I have this on 4.18, please ? :)

…nHoogland comments.

soreana · 2022-10-10T15:31:17Z

@blueorangutan package

blueorangutan · 2022-10-10T15:32:03Z

@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-10-10T16:23:32Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4411

DaanHoogland · 2022-10-11T15:06:19Z

@blueorangutan test

soreana · 2022-10-17T19:36:14Z

@soreana , some simple changes sugested by sonar. I am running another suite of tests. There is also a suggestion to externalise a string, but I'd leave that one for a separate cleanup-PR.

@DaanHoogland Thanks for the reviews and the tests. Personally, I don't prefer to touch that Throwable line. It may break something unwanted :-)

blueorangutan · 2022-10-17T22:34:46Z

Trillian test result (tid-5157)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37725 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6781-t5157-kvm-centos7.zip
Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

soreana · 2022-10-18T07:49:18Z

@DaanHoogland Can I also have this one in 4.18? 🙈

DaanHoogland · 2022-10-19T07:22:05Z

@andrijapanicsb @JoaoJandre @sureshanaparti , are all your comments and requests met?

weizhouapache · 2023-01-03T16:22:00Z

@blueorangutan package

blueorangutan · 2023-01-03T16:23:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-01-03T17:18:41Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5161

soreana · 2023-01-03T17:24:31Z

@DaanHoogland Can I have this on 4.18? 🙈
There isn't any astounding comment. :)

DaanHoogland · 2023-01-04T10:36:11Z

@blueorangutan test

blueorangutan · 2023-01-04T10:37:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-01-04T23:31:57Z

Trillian test result (tid-5742)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45176 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6781-t5742-kvm-centos7.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_07_deploy_kubernetes_ha_cluster	`Failure`	3618.19	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	67.72	test_kubernetes_clusters.py

sonarqubecloud · 2023-01-05T09:52:50Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

4.7% Coverage
0.0% Duplication

boring-cyborg bot added component:integration-test component:marvin component:networking Python Warning... Python code Ahead! labels Sep 28, 2022

DaanHoogland reviewed Sep 29, 2022

View reviewed changes

Comment thread test/integration/component/test_multiple_physical_network_creation.py Outdated

DaanHoogland requested review from andrijapanicsb and weizhouapache September 29, 2022 13:32

Sina Kashipazha added 2 commits October 10, 2022 17:09

Allow creating atmost 1 physical network with null tag

3ddb1b3

House keeping multiple_physical_network_creation.py in regards to Daa…

d094d84

…nHoogland comments.

soreana force-pushed the physical_network_with_null_tag branch from f34229c to d094d84 Compare October 10, 2022 15:10

removed Unnecessary cleanups.

8b30f04

soreana requested review from JoaoJandre and sureshanaparti and removed request for JoaoJandre, andrijapanicsb and sureshanaparti November 3, 2022 13:51

soreana requested review from JoaoJandre and sureshanaparti and removed request for JoaoJandre and sureshanaparti December 5, 2022 10:40

DaanHoogland closed this Jan 5, 2023

DaanHoogland reopened this Jan 5, 2023

DaanHoogland merged commit 20306d6 into apache:main Jan 5, 2023

weizhouapache mentioned this pull request Aug 15, 2023

listNetworkOfferings api does not handle phyiscal network tags correctly #6747

Closed

weizhouapache mentioned this pull request Dec 1, 2023

UI doesn't allow creating Guest Traffic on more than one Physical Network when existing Guest Traffic is not tagged. #8279

Closed

GutoVeronezi mentioned this pull request Dec 4, 2025

Fix API deleteTrafficType not filtering physical network II #12184

Merged

10 tasks

Conversation

soreana commented Sep 28, 2022

Description

Types of changes

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

DaanHoogland commented Sep 28, 2022

Uh oh!

blueorangutan commented Sep 28, 2022

Uh oh!

codecov bot commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Sep 28, 2022

Uh oh!

DaanHoogland commented Sep 29, 2022

Uh oh!

blueorangutan commented Sep 29, 2022

Uh oh!

DaanHoogland commented Sep 29, 2022

Uh oh!

soreana commented Sep 29, 2022

Uh oh!

acs-robot commented Sep 29, 2022

Uh oh!

blueorangutan commented Sep 29, 2022

Uh oh!

soreana commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Sep 29, 2022

Uh oh!

Uh oh!

DaanHoogland commented Sep 29, 2022

Uh oh!

blueorangutan commented Sep 29, 2022

Uh oh!

soreana commented Oct 10, 2022

Uh oh!

soreana commented Oct 10, 2022

Uh oh!

blueorangutan commented Oct 10, 2022

Uh oh!

blueorangutan commented Oct 10, 2022

Uh oh!

DaanHoogland commented Oct 11, 2022

Uh oh!

soreana commented Oct 17, 2022

Uh oh!

blueorangutan commented Oct 17, 2022

Uh oh!

soreana commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Oct 19, 2022

Uh oh!

weizhouapache commented Jan 3, 2023

Uh oh!

blueorangutan commented Jan 3, 2023

Uh oh!

blueorangutan commented Jan 3, 2023

Uh oh!

soreana commented Jan 3, 2023

Uh oh!

DaanHoogland commented Jan 4, 2023

Uh oh!

blueorangutan commented Jan 4, 2023

Uh oh!

blueorangutan commented Jan 4, 2023

Uh oh!

sonarqubecloud bot commented Jan 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

codecov bot commented Sep 28, 2022 •

edited

Loading

soreana commented Sep 29, 2022 •

edited

Loading

soreana commented Oct 18, 2022 •

edited

Loading