Filter templates in vue

[DaanHoogland]

Description

This PR...

Fixes: #7560

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested manually in the UI on and environment with two zones with different hypervisors.

An alternative way of testing could be testing in a single zone with two different hypervisor types or in two zones with the same hypervisor type. In both cases the list of available templates to choose from should be restricted to the current zone and hypervisor type. I.E. and template that is of a different hypervisortype or not available in the zone the VM is in should not be offered as a choice in the drop-down.

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7739 (QA-JID-124)

[codecov]

Codecov Report

Merging #7739 (0b368b7) into 4.18 (939ee9e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7739   +/-   ##
=========================================
  Coverage     13.02%   13.02%           
- Complexity     9026     9027    +1     
=========================================
  Files          2719     2719           
  Lines        256867   256867           
  Branches      40051    40051           
=========================================
+ Hits          33445    33447    +2     
  Misses       219233   219233           
+ Partials       4189     4187    -2     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[soreana]

@DaanHoogland Shouldn't we also fix the api call as well? In my view, those templates shouldn't be visible in the front end at all.

[DaanHoogland]

@DaanHoogland Shouldn't we also fix the api call as well? In my view, those templates shouldn't be visible in the front end at all.

No, i don´t see why @soreana. The user has rights to see those templates, it is just that these are not applicable for restoring the VM.

[soreana]

So

@DaanHoogland Shouldn't we also fix the api call as well? In my view, those templates shouldn't be visible in the front end at all.

No, i don´t see why @soreana. The user has rights to see those templates, it is just that these are not applicable for restoring the VM.

Yeah I agree that this is a default behaviour and user can see those. My question is what would be the point of showing those templates to user while they can't use them :D

[DaanHoogland]

So

@DaanHoogland Shouldn't we also fix the api call as well? In my view, those templates shouldn't be visible in the front end at all.

No, i don´t see why @soreana. The user has rights to see those templates, it is just that these are not applicable for restoring the VM.

Yeah I agree that this is a default behaviour and user can see those. My question is what would be the point of showing those templates to user while they can't use them :D

none, that is why this PR (and why #7560 was reported) . Not sure I get your comment @soreana .

to be extra clear:
because we don't know why th user calls listTemplates, in this pr we filter the templates in the call in the UI for restoring a VM, as the limitation makes sense there.
We cannot do the filtering in the API because the call may for instance be done in cloudmonkey, just to see which one they want to download to install on their laptop.
So in the UI I implemented a filter in the call listTemplates with added parameters for hypevisortype and zoneid.

[kiranchavala]

@blueorangutan package

[blueorangutan]

@kiranchavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6514

[kiranchavala]

LGTM

Tested manually and only the zone specific templates are visible when you try to reinstall a vm

[DaanHoogland]

@weizhouapache can you review?

[DaanHoogland]

second test verification reported at #7560 (comment)

[weizhouapache]

code lgtm

[weizhouapache]

@DaanHoogland
it looks UI test failed after merging this
https://github.com/apache/cloudstack/actions/runs/5710998969/job/15472424976

[DaanHoogland]

see #7792

@DaanHoogland it looks UI test failed after merging this https://github.com/apache/cloudstack/actions/runs/5710998969/job/15472424976