Skip to content

fix units labels for max storage of volume#8001

Merged
yadvr merged 1 commit intoapache:4.18from
oscaralvaro:storage_max_volume_size
Sep 26, 2023
Merged

fix units labels for max storage of volume#8001
yadvr merged 1 commit intoapache:4.18from
oscaralvaro:storage_max_volume_size

Conversation

@oscaralvaro
Copy link
Copy Markdown
Contributor

Description

This PR...
Change units from Gigabyte to Gibibyte for maximum size for a volume

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text looks good

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 26, 2023

Codecov Report

Merging #8001 (686c774) into 4.18 (29c7b31) will increase coverage by 0.04%.
Report is 57 commits behind head on 4.18.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##               4.18    #8001      +/-   ##
============================================
+ Coverage     13.02%   13.06%   +0.04%     
- Complexity     9032     9105      +73     
============================================
  Files          2720     2720              
  Lines        257080   257500     +420     
  Branches      40088    40149      +61     
============================================
+ Hits          33476    33642     +166     
- Misses       219400   219629     +229     
- Partials       4204     4229      +25     
Files Coverage Δ
...hestration/service/VolumeOrchestrationService.java 100.00% <ø> (ø)
.../main/java/com/cloud/network/IpAddressManager.java 100.00% <100.00%> (ø)
...ava/com/cloud/network/as/AutoScaleVmProfileVO.java 80.20% <100.00%> (+11.66%) ⬆️
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java 40.89% <100.00%> (+0.64%) ⬆️
...va/com/cloud/upgrade/DatabaseVersionHierarchy.java 85.10% <100.00%> (+1.01%) ⬆️
.../api/command/admin/ratelimit/ResetApiLimitCmd.java 0.00% <ø> (ø)
...oud/hypervisor/kvm/resource/LibvirtConnection.java 0.00% <ø> (ø)
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java 10.44% <100.00%> (ø)
...ava/com/cloud/api/commands/StopNetScalerVMCmd.java 0.00% <ø> (ø)
...tungsten/api/command/ListTungstenFabricTagCmd.java 0.00% <ø> (ø)
... and 53 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yadvr yadvr modified the milestones: 4.19.0.0, 4.18.2.0 Sep 26, 2023
@yadvr yadvr merged commit 8aa45c1 into apache:4.18 Sep 26, 2023
DaanHoogland added a commit that referenced this pull request Sep 28, 2023
* 4.18:
  VR: remove apache2 config for removed VPC tiers (#7982)
  fix units labels (#8001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants