fix: cleanup directory if empty after removal of snapshot

[vishesh92]

Description

This PR removes the directory of snapshot if it's empty after removal of snapshot.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

did a quick test with hidden files and code looks good

[codecov]

Codecov Report

Merging #8002 (20a2085) into 4.18 (29c7b31) will increase coverage by 0.04%.
Report is 58 commits behind head on 4.18.
The diff coverage is 20.00%.

❗ Current head 20a2085 differs from pull request most recent head c4c631f. Consider uploading reports for the commit c4c631f to get more accurate results

@@             Coverage Diff              @@
##               4.18    #8002      +/-   ##
============================================
+ Coverage     13.02%   13.06%   +0.04%     
- Complexity     9032     9106      +74     
============================================
  Files          2720     2720              
  Lines        257080   257500     +420     
  Branches      40088    40149      +61     
============================================
+ Hits          33476    33649     +173     
- Misses       219400   219621     +221     
- Partials       4204     4230      +26     

Files	Coverage Δ
.../main/java/com/cloud/network/IpAddressManager.java	100.00% <100.00%> (ø)
...ava/com/cloud/network/as/AutoScaleVmProfileVO.java	80.20% <100.00%> (+11.66%)	⬆️
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java	40.89% <100.00%> (+0.64%)	⬆️
...va/com/cloud/upgrade/DatabaseVersionHierarchy.java	85.10% <100.00%> (+1.01%)	⬆️
.../api/command/admin/ratelimit/ResetApiLimitCmd.java	0.00% <ø> (ø)
...oud/hypervisor/kvm/resource/LibvirtConnection.java	0.00% <ø> (ø)
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java	10.44% <100.00%> (ø)
...ava/com/cloud/api/commands/StopNetScalerVMCmd.java	0.00% <ø> (ø)
...tungsten/api/command/ListTungstenFabricTagCmd.java	0.00% <ø> (ø)
.../com/cloud/network/guru/VxlanGuestNetworkGuru.java	56.36% <100.00%> (ø)
... and 52 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7109

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7110

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7723)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52298 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8002-t7723-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	3616.43	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	545.40	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	3614.89	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	0.08	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.09	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.09	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.10	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Error	5.53	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	65.93	test_kubernetes_clusters.py

[harikrishna-patnala]

code LGTM