Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host by harikrishna-patnala · Pull Request #8049 · apache/cloudstack

harikrishna-patnala · 2023-10-06T09:13:00Z

Description

This PR fixes the issue #8040

we are now handling any exception while setting up the memory balloon stats period

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

harikrishna-patnala · 2023-10-06T09:13:27Z

@blueorangutan package

blueorangutan · 2023-10-06T09:14:04Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

…VM VMs

blueorangutan · 2023-10-06T10:13:36Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7252

harikrishna-patnala · 2023-10-06T10:20:43Z

@blueorangutan package

blueorangutan · 2023-10-06T10:22:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache

code lgtm

codecov · 2023-10-06T11:03:34Z

Codecov Report

Merging #8049 (788e08b) into 4.18 (a20ab40) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##               4.18    #8049   +/-   ##
=========================================
  Coverage     13.07%   13.07%           
- Complexity     9109     9110    +1     
=========================================
  Files          2720     2720           
  Lines        257530   257535    +5     
  Branches      40154    40156    +2     
=========================================
+ Hits          33660    33668    +8     
+ Misses       219639   219633    -6     
- Partials       4231     4234    +3

Files	Coverage Δ
...ervisor/kvm/resource/LibvirtComputingResource.java	`18.45% <0.00%> (ø)`
...ypervisor/kvm/resource/LibvirtDomainXMLParser.java	`50.00% <40.00%> (-0.62%)`	⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

blueorangutan · 2023-10-06T11:20:28Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7253

DaanHoogland · 2023-10-06T11:45:29Z

                        currentVmBalloonStatsPeriod, vmId, dm.getName()));
-            } catch (final LibvirtException e) {
-                s_logger.warn("Failed to set up memory balloon stats period." + e.getMessage());
+            } catch (final Exception e) {


Is this needed or can we add a specific Exception to the catch clause?

@DaanHoogland we are trying to read many other parameters in that parser. so there are chances of other errors such as NPEs, cast errors. While discussing with Wei several other found in IDE, so thought a common exception could catch it and warn the message.

ok, I hate it and I would like to see a message per exception, but no -1 for that

:) So you are giving +1 on this right ;)

GutoVeronezi · 2023-10-09T10:38:55Z

Should we consider VMs not managed by ACS in Agent start up? Would not it be easier to filter out those VMs?

weizhouapache · 2023-10-09T10:41:43Z

Should we consider VMs not managed by ACS in Agent start up? Would not it be easier to filter out those VMs?

@GutoVeronezi
we had some discussion on the issue #8040
the problem is how to accurately determine if a vm is managed on ACS or not in kvm agent (which cannot read cloudstack database), especially considering that the kvm import feature will be introduced in 4.19

GutoVeronezi · 2023-10-09T10:46:02Z

Should we consider VMs not managed by ACS in Agent start up? Would not it be easier to filter out those VMs?

@GutoVeronezi we had some discussion on the issue #8040 the problem is how to accurately determine if a vm is managed on ACS or not in kvm agent (which cannot read cloudstack database), especially considering that the kvm import feature will be introduced in 4.19

I see, thanks @weizhouapache.

weizhouapache · 2023-10-11T18:58:07Z

@blueorangutan package

blueorangutan · 2023-10-11T19:00:03Z

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-11T19:57:58Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7329

DaanHoogland

+0

harikrishna-patnala · 2023-10-19T05:18:36Z

@DaanHoogland do you want me to improve this code to handle specific exceptions ?

DaanHoogland · 2023-10-19T08:07:09Z

@DaanHoogland do you want me to improve this code to handle specific exceptions ?

I would prefer that but am not going to -1 this PR because of it.

yadvr

LGTM - didn't test it though

weizhouapache · 2023-10-27T08:53:14Z

@DaanHoogland @harikrishna-patnala
I think it is not a problem if ACS fails to set the memory ballooning of a specific VM, we could silently ignore the error, no matter what exceptions (LibvirtException, NPE, or others) are thrown.

DaanHoogland · 2023-10-27T08:54:52Z

@DaanHoogland @harikrishna-patnala I think it is not a problem if ACS fails to set the memory ballooning of a specific VM, we could silently ignore the error, no matter what exceptions (LibvirtException, NPE, or others) are thrown.

ok, I would like to see that justification near the catch as to not encourage this kind of coding too much.

DaanHoogland · 2023-10-27T08:55:13Z

@blueorangutan package

blueorangutan · 2023-10-27T08:56:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-27T10:12:55Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7545

DaanHoogland · 2023-10-27T10:55:07Z

@blueorangutan LLtest basicZone

blueorangutan · 2023-10-27T10:56:03Z

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2023-10-27T10:57:26Z

@blueorangutan LLtest securityGroups

blueorangutan · 2023-10-27T10:58:03Z

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2023-10-27T11:57:32Z

@blueorangutan test rocky8 kvm-rocky8

blueorangutan · 2023-10-27T11:58:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

blueorangutan · 2023-10-27T14:46:20Z

[LL]Trillian test result (tid-6872)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 12259 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8049-t6872-kvm-centos7.zip
Smoke tests completed. 100 look OK, 9 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestIpv6Network>:setup	`Error`	0.00	test_network_ipv6.py
test_01_create_ipv6_public_ip_range	`Error`	0.02	test_ipv6_infra.py
test_deploy_more_vms_than_limit_allows	`Failure`	50.48	test_deploy_vms_in_parallel.py
test_03_restart_network_cleanup	`Error`	1.08	test_routers.py
test_01_events_resource	`Error`	1.84	test_events_resource.py
test_CRUD_operations_userdata	`Error`	1.76	test_register_userdata.py
test_deploy_vm_with_registered_userdata	`Error`	1.80	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	`Error`	1.76	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	`Error`	1.78	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny	`Error`	1.76	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	`Error`	1.78	test_register_userdata.py
test_link_and_unlink_userdata_to_template	`Error`	1.77	test_register_userdata.py
test_user_userdata_crud	`Error`	1.76	test_register_userdata.py
test_08_migrate_vm	`Error`	1.15	test_vm_life_cycle.py
ContextSuite context=TestIpv6Vpc>:setup	`Error`	0.00	test_vpc_ipv6.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	0.22	test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure	`Error`	0.27	test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:setup	`Error`	0.42	test_host_maintenance.py

blueorangutan · 2023-10-28T01:46:35Z

[SF] Trillian test result (tid-8138)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 47615 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8049-t8138-kvm-rocky8.zip
Smoke tests completed. 109 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2023-10-28T03:19:34Z

[LL]Trillian test result (tid-6873)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57333 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8049-t6873-kvm-centos7.zip
Smoke tests completed. 56 look OK, 53 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestPortablePublicIPAcquire>:setup	`Error`	0.00	test_portable_publicip.py
test_DeleteDomain	`Failure`	93.41	test_accounts.py
test_forceDeleteDomain	`Failure`	90.33	test_accounts.py
test_delete_account	`Error`	43.34	test_network.py
test_delete_network_while_vm_on_it	`Error`	1.12	test_network.py
test_deploy_vm_l2network	`Error`	1.11	test_network.py
test_l2network_restart	`Error`	2.23	test_network.py
test_01_port_fwd_on_src_nat	`Failure`	0.02	test_network.py
test_02_port_fwd_on_non_src_nat	`Error`	0.03	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	3.46	test_network.py
test_reboot_router	`Error`	160.27	test_network.py
test_releaseIP	`Error`	39.19	test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule	`Error`	0.03	test_network.py
test_network_rules_acquired_public_ip_2_nat_rule	`Error`	0.02	test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule	`Error`	0.02	test_network.py
test_network_acl	`Error`	2.16	test_network_acl.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	4.43	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Failure`	4.48	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	3.39	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	4.46	test_internal_lb.py
ContextSuite context=TestIpv6Network>:setup	`Error`	0.00	test_network_ipv6.py
test_01_nic	`Error`	42.95	test_nic.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
test_01_create_ipv6_public_ip_range	`Error`	0.02	test_ipv6_infra.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
test_01_ping_in_vr_success	`Failure`	0.02	test_diagnostics.py
test_02_ping_in_vr_failure	`Failure`	0.01	test_diagnostics.py
test_07_arping_in_vr	`Failure`	0.01	test_diagnostics.py
test_10_traceroute_in_vr	`Failure`	0.01	test_diagnostics.py
test_13_retrieve_vr_default_files	`Failure`	0.02	test_diagnostics.py
test_14_retrieve_vr_one_file	`Failure`	0.01	test_diagnostics.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_deploy_vm_from_direct_download_template_nfs_storage	`Error`	0.08	test_direct_download.py
test_01_isolated_persistent_network	`Error`	0.03	test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist	`Failure`	1.25	test_persistent_network.py
test_01_vpc_privategw_acl	`Failure`	4.95	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	4.87	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	4.97	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	3.89	test_privategw_acl.py
test_01_native_to_native_network_migration	`Error`	1.92	test_migration.py
test_02_native_to_native_vpc_migration	`Error`	5.09	test_migration.py
test_04_verify_guest_lspci	`Error`	810.72	test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_again	`Error`	810.44	test_deploy_virtio_scsi_vm.py
test_01_create_delete_portforwarding_fornonvpc	`Error`	1.76	test_portforwardingrules.py
ContextSuite context=TestNetworkPermissions>:setup	`Error`	0.00	test_network_permissions.py
test_03_create_network_domain_network_offering	`Error`	5.28	test_domain_network_offerings.py
test_extendPhysicalNetworkVlan	`Error`	0.03	test_non_contigiousvlan.py
test_03_create_vpc_domain_vpc_offering	`Error`	6.38	test_domain_vpc_offerings.py
test_01_router_internal_basic	`Failure`	0.02	test_routers.py
test_02_router_internal_adv	`Failure`	0.01	test_routers.py
test_03_restart_network_cleanup	`Failure`	0.01	test_routers.py
test_04_restart_network_wo_cleanup	`Failure`	2.10	test_routers.py
test_05_router_basic	`Failure`	0.01	test_routers.py
test_06_router_advanced	`Failure`	0.01	test_routers.py
test_07_stop_router	`Failure`	0.01	test_routers.py
test_08_start_router	`Failure`	0.01	test_routers.py
test_09_reboot_router	`Failure`	0.01	test_routers.py
test_10_reboot_router_forced	`Failure`	0.01	test_routers.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	40.05	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	77.98	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	115.96	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	244.71	test_usage.py
test_01_events_resource	`Error`	1.78	test_events_resource.py
ContextSuite context=TestNonStrictAffinityGroups>:setup	`Error`	0.00	test_nonstrict_affinity_group.py
test_dedicatePublicIpRange	`Error`	0.02	test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms	`Error`	0.01	test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_01_ssvm	`Error`	0.05	test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_02_cpvm	`Error`	0.05	test_public_ip_range.py
test_create_pvlan_network	`Error`	0.06	test_pvlan.py
test_dedicateGuestVlanRange	`Error`	0.00	test_guest_vlan_range.py
ContextSuite context=TestDedicateGuestVlanRange>:teardown	`Error`	0.00	test_guest_vlan_range.py
ContextSuite context=TestHostControlState>:setup	`Error`	0.00	test_host_control_state.py
test_CRUD_operations_userdata	`Error`	1.76	test_register_userdata.py
test_deploy_vm_with_registered_userdata	`Error`	1.72	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	`Error`	1.78	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	`Error`	1.72	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny	`Error`	1.77	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	`Error`	1.73	test_register_userdata.py
test_link_and_unlink_userdata_to_template	`Error`	1.72	test_register_userdata.py
test_user_userdata_crud	`Error`	1.75	test_register_userdata.py
test_01_create_iso_with_checksum_sha1	`Error`	66.40	test_iso.py
test_02_create_iso_with_checksum_sha256	`Error`	66.37	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	66.38	test_iso.py
test_04_create_iso_with_no_checksum	`Error`	66.37	test_iso.py
test_01_create_iso	`Failure`	1514.03	test_iso.py
ContextSuite context=TestISO>:setup	`Error`	3027.15	test_iso.py
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
ContextSuite context=TestIsolatedNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
test_01_add_delete_kubernetes_supported_version	`Error`	0.04	test_kubernetes_supported_versions.py
test_01_sys_vm_start	`Failure`	0.07	test_secondary_storage.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.14	test_service_offerings.py
ContextSuite context=TestVMWareStoragePolicies>:setup	`Error`	0.00	test_storage_policy.py
ContextSuite context=TestVmAutoScaling>:setup	`Error`	0.00	test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host	`Error`	1.21	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	1.19	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.25	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	1.21	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.18	test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	2.84	test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	2.84	test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	4.07	test_volumes.py
ContextSuite context=TestIpv6Vpc>:setup	`Error`	0.00	test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible	`Error`	1512.26	test_hostha_kvm.py

DaanHoogland · 2023-10-30T07:26:51Z

smoke tests for security groups and basic zone are expected to have such a low pass rate.
regular smoke tests look fine

rajujith

LGTM. Observed a similar issue parsing domain XML for a VM created outside Cloudstack with 4.18.1, and confirmed this PR fixes the issue.

2023-11-03 06:43:58,568 ERROR [cloud.agent.AgentShell] (main:null) (logid:) Unable to start agent:
javax.naming.ConfigurationException: Error while creating Agent with class [com.cloud.hypervisor.kvm.resource.LibvirtComputingResource]. [Root exception is java.lang.IllegalArgumentException: No enum constant com.cloud.hypervisor.kvm.resource.LibvirtVMDef.ChannelDef.ChannelType.SPICEVMC]
	at com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:434)
	at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:415)
	at com.cloud.agent.AgentShell.start(AgentShell.java:511)
	at com.cloud.agent.AgentShell.main(AgentShell.java:541)
Caused by: java.lang.IllegalArgumentException: No enum constant com.cloud.hypervisor.kvm.resource.LibvirtVMDef.ChannelDef.ChannelType.SPICEVMC
	at java.base/java.lang.Enum.valueOf(Enum.java:240)
	at com.cloud.hypervisor.kvm.resource.LibvirtVMDef$ChannelDef$ChannelType.valueOf(LibvirtVMDef.java:1768)
	at com.cloud.hypervisor.kvm.resource.LibvirtDomainXMLParser.parseDomainXML(LibvirtDomainXMLParser.java:273)
	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.setupMemoryBalloonStatsPeriod(LibvirtComputingResource.java:1301)
	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.configure(LibvirtComputingResource.java:1244)
	at com.cloud.agent.Agent.<init>(Agent.java:190)
	at com.cloud.agent.AgentShell.launchNewAgent(AgentShell.java:452)
	at com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:431)
	... 3 more

…for KVM VMs (apache#8049)

… period for KVM VMs (apache#8049)" This reverts commit f0482e5.

…on stats period for KVM VMs (apache#8049)"" This reverts commit bb2ebbf.

… period for KVM VMs (apache#8049)" This reverts commit f0482e5.

boring-cyborg bot added the component:kvm label Oct 6, 2023

harikrishna-patnala added this to the 4.18.2.0 milestone Oct 6, 2023

Handle the failures when setting up memory balloon stats period for K…

788e08b

…VM VMs

harikrishna-patnala force-pushed the handleKVMmemoryBalloonSafely branch from f7e7661 to 788e08b Compare October 6, 2023 09:43

harikrishna-patnala requested a review from weizhouapache October 6, 2023 09:45

weizhouapache approved these changes Oct 6, 2023

View reviewed changes

DaanHoogland reviewed Oct 6, 2023

View reviewed changes

harikrishna-patnala requested review from DaanHoogland, GutoVeronezi and shwstppr October 12, 2023 04:32

DaanHoogland reviewed Oct 12, 2023

View reviewed changes

yadvr approved these changes Oct 27, 2023

View reviewed changes

apache deleted a comment from blueorangutan Oct 27, 2023

DaanHoogland approved these changes Oct 30, 2023

View reviewed changes

rajujith self-assigned this Nov 3, 2023

rajujith approved these changes Nov 3, 2023

View reviewed changes

weizhouapache merged commit 1e133d0 into apache:4.18 Nov 3, 2023

DaanHoogland deleted the handleKVMmemoryBalloonSafely branch November 3, 2023 08:15

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 8, 2023

kvm: Handle the failures when setting up memory balloon stats period …

f0482e5

…for KVM VMs (apache#8049)

DaanHoogland mentioned this pull request Nov 9, 2023

Cannot start cloudstack-agent if there is vm not managed by cloudstack on the host #8040

Closed

Dajeong-Park added a commit to Dajeong-Park/ablestack-cloud that referenced this pull request Nov 15, 2023

Revert "kvm: Handle the failures when setting up memory balloon stats…

bb2ebbf

… period for KVM VMs (apache#8049)" This reverts commit f0482e5.

Dajeong-Park added a commit to Dajeong-Park/ablestack-cloud that referenced this pull request Nov 15, 2023

Revert "Revert "kvm: Handle the failures when setting up memory ballo…

6650fda

…on stats period for KVM VMs (apache#8049)"" This reverts commit bb2ebbf.

Dajeong-Park added a commit to Dajeong-Park/ablestack-cloud that referenced this pull request Nov 16, 2023

Revert "kvm: Handle the failures when setting up memory balloon stats…

93e4756

… period for KVM VMs (apache#8049)" This reverts commit f0482e5.

Conversation

harikrishna-patnala commented Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

harikrishna-patnala commented Oct 6, 2023

Uh oh!

blueorangutan commented Oct 6, 2023

Uh oh!

blueorangutan commented Oct 6, 2023

Uh oh!

harikrishna-patnala commented Oct 6, 2023

Uh oh!

blueorangutan commented Oct 6, 2023

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 6, 2023

Codecov Report

Uh oh!

blueorangutan commented Oct 6, 2023

Uh oh!

DaanHoogland Oct 6, 2023

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala Oct 9, 2023

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Oct 9, 2023

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala Oct 9, 2023

Choose a reason for hiding this comment

Uh oh!

GutoVeronezi commented Oct 9, 2023

Uh oh!

weizhouapache commented Oct 9, 2023

Uh oh!

GutoVeronezi commented Oct 9, 2023

Uh oh!

weizhouapache commented Oct 11, 2023

Uh oh!

blueorangutan commented Oct 11, 2023

Uh oh!

blueorangutan commented Oct 11, 2023

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala commented Oct 19, 2023

Uh oh!

DaanHoogland commented Oct 19, 2023

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Oct 27, 2023

Uh oh!

DaanHoogland commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Oct 27, 2023

Uh oh!

blueorangutan commented Oct 27, 2023

Uh oh!

blueorangutan commented Oct 27, 2023

Uh oh!

DaanHoogland commented Oct 27, 2023

Uh oh!

blueorangutan commented Oct 27, 2023

Uh oh!

DaanHoogland commented Oct 27, 2023

harikrishna-patnala commented Oct 6, 2023 •

edited

Loading

DaanHoogland commented Oct 27, 2023 •

edited

Loading