Skip to content

pom.xml: upgrade trilead-ssh2 verison#8198

Closed
weizhouapache wants to merge 1 commit intoapache:4.18from
weizhouapache:4.18-upgrade-trilead-ssh2
Closed

pom.xml: upgrade trilead-ssh2 verison#8198
weizhouapache wants to merge 1 commit intoapache:4.18from
weizhouapache:4.18-upgrade-trilead-ssh2

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache changed the base branch from main to 4.18 November 8, 2023 14:48
@weizhouapache weizhouapache reopened this Nov 8, 2023
@weizhouapache
Copy link
Copy Markdown
Member Author

@soreana @kriegsmanj can you test this ?
this probably fixes #8055

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@soreana
Copy link
Copy Markdown
Member

soreana commented Nov 8, 2023

@soreana @kriegsmanj can you test this ? this probably fixes #8055

@weizhouapache I'm checking that. Thanks 🙏

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7679

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 8, 2023

Codecov Report

Merging #8198 (a232f85) into 4.18 (11b5831) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #8198      +/-   ##
============================================
- Coverage     13.10%   13.09%   -0.01%     
- Complexity     9121     9122       +1     
============================================
  Files          2720     2720              
  Lines        257599   257599              
  Branches      40158    40158              
============================================
- Hits          33747    33740       -7     
- Misses       219588   219596       +8     
+ Partials       4264     4263       -1     

see 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan test matrix

Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to check/test that this doesn’t bring any regressions

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-8283)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50905 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8198-t8283-kvm-centos7.zip
Smoke tests completed. 108 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_invalid_upgrade_kubernetes_cluster Failure 3622.99 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 3610.74 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.05 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Failure 46.09 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 101.52 test_kubernetes_clusters.py

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-8282)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 52612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8198-t8282-vmware-67u3.zip
Smoke tests completed. 106 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_ping_in_ssvm_success Error 1.12 test_diagnostics.py
test_04_ping_in_ssvm_failure Error 1.12 test_diagnostics.py
test_08_arping_in_ssvm Error 1.12 test_diagnostics.py
test_09_arping_in_cpvm Error 1.12 test_diagnostics.py
test_11_traceroute_in_ssvm Error 1.12 test_diagnostics.py
test_15_retrieve_ssvm_default_files Error 2.66 test_diagnostics.py
test_16_retrieve_ssvm_single_file Error 1.13 test_diagnostics.py
test_01_add_primary_storage_disabled_host Error 35.65 test_primary_storage.py
test_01_non_strict_host_anti_affinity Failure 144.32 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 103.02 test_nonstrict_affinity_group.py

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM, but needs extensive testing (component test suites?)

@soreana
Copy link
Copy Markdown
Member

soreana commented Nov 10, 2023

@weizhouapache I tested the PR, it didn't fix #8055 . Without these changes, it took roughly 10 minutes to restart a VPC with cleanup in an empty test environment. After applying the changes, the same VPC still required around 10 minutes for the restart.

Also tested VM deployments and ACL assignments they worked fine.

@weizhouapache
Copy link
Copy Markdown
Member Author

@weizhouapache I tested the PR, it didn't fix #8055 . Without these changes, it took roughly 10 minutes to restart a VPC with cleanup in an empty test environment. After applying the changes, the same VPC still required around 10 minutes for the restart.

Also tested VM deployments and ACL assignments they worked fine.

thanks @soreana
that's not good to know ;-D let's discuss in the issue #8055

@DaanHoogland
Copy link
Copy Markdown
Contributor

Do we think this should be merged anyway?

@weizhouapache
Copy link
Copy Markdown
Member Author

closing as it did not help #8055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants