systemvm: add template_zone_ref record when add a new zone with same hypervisor type

[weizhouapache]

Description

This PR should fix #8388

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

The fix ensures that when you have at least one Zone with a specific hypervisor type (e.g. KVM), then when adding a new Zone with the same hypervisor type, even if the systemVM template for that hypervisor (when registered in the original Zone) is not marked as cross_zone=1 (in vm_template table) - i.e. when it's not marked for "ALL ZONES" - CloudStack will created the record in the template_zone_ref table, and the rest of the work will be done by the automatic systemVM template installation script (that runs when a first Secondary Storage is added inside a new Zone)

[weizhouapache]

cc @andrijapanicsb

[DaanHoogland]

clgtm

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 13.12%. Comparing base (9d3a7be) to head (256328f).
Report is 29 commits behind head on 4.18.

Files	Patch %	Lines
...om/cloud/upgrade/SystemVmTemplateRegistration.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.18    #8395   +/-   ##
=========================================
  Coverage     13.12%   13.12%           
  Complexity     9141     9141           
=========================================
  Files          2720     2720           
  Lines        257723   257723           
  Branches      40177    40177           
=========================================
  Hits          33838    33838           
  Misses       219595   219595           
  Partials       4290     4290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sureshanaparti]

changes lgtm

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8116

[weizhouapache]

@blueorangutan LLtest matrix

[yadvr]

@blueorangutan LLtest matrix

[blueorangutan]

@rohityadavcloud a [LL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[andrijapanicsb]

LGTM

(updated the desc, so it becomes readable for regular mortals :)

[blueorangutan]

[LL] Trillian Build Failed (tid-6904)

[blueorangutan]

[LL] Trillian Build Failed (tid-6906)

[blueorangutan]

[LL] Trillian Build Failed (tid-6905)

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-8657)

[blueorangutan]

[LL] Trillian Build Failed (tid-6907)

[blueorangutan]

[LL] Trillian Build Failed (tid-6908)

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8125

[weizhouapache]

@blueorangutan LLtest

[blueorangutan]

@weizhouapache a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8521

[yadvr]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9187)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43159 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8395-t9187-kvm-centos7.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	668.19	test_kubernetes_clusters.py

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9390

[DaanHoogland]

@blueorangutan test rocky8 kvm-rocky8

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9981)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49175 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8395-t9981-kvm-rocky8.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[weizhouapache]

merging based on approvals and CI tests