Skip to content

Upgrade org.json:json version#8750

Merged
yadvr merged 1 commit intoapache:4.18from
shapeblue:upgrade-json-version
Apr 30, 2024
Merged

Upgrade org.json:json version#8750
yadvr merged 1 commit intoapache:4.18from
shapeblue:upgrade-json-version

Conversation

@vishesh92
Copy link
Copy Markdown
Member

Description

This PR fixes #8696

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (223a9b8) to head (71d6a20).
Report is 5 commits behind head on 4.18.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.18    #8750   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
  Complexity     9205     9205           
=========================================
  Files          2724     2724           
  Lines        258149   258149           
  Branches      40235    40235           
=========================================
  Hits          33987    33987           
  Misses       219856   219856           
  Partials       4306     4306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8867

@vishesh92
Copy link
Copy Markdown
Member Author

@blueorangutan test matrix

@blueorangutan
Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had to upgrade in #8674

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti sureshanaparti added this to the 4.18.2.0 milestone Mar 7, 2024
@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-9416)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38528 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8750-t9416-xenserver-71.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-9418)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39467 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8750-t9418-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-9417)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 45660 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8750-t9417-vmware-67u3.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan test alma9 kvm-alma9

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-9435)

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-9452)

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-9461)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Mar 13, 2024

@blueorangutan test ol9 kvm-ol9

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud [SL] unsupported parameters provided. Supported mgmt server os are: centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-9454)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 40392 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8750-t9454-kvm-rocky8.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan test alma9 kvm-alma9

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-9506)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 43307 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8750-t9506-kvm-alma9.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@JoaoJandre JoaoJandre modified the milestones: 4.18.2.0, 4.18.3 Mar 21, 2024
@DaanHoogland
Copy link
Copy Markdown
Contributor

@sureshanaparti @vishesh92 , do you think we need more testing for this (cc @borisstoyanov )

@yadvr yadvr modified the milestones: 4.18.3, 4.19.1.0 Apr 30, 2024
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Apr 30, 2024

Looks like all automated tests are passing @DaanHoogland I say this LGTM, let's merge. We can revert if we find any issues later (or apply further changes).

@yadvr yadvr merged commit 5c9d79e into apache:4.18 Apr 30, 2024
@yadvr yadvr deleted the upgrade-json-version branch April 30, 2024 12:53
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

8 participants