Fix VM import & VM delete with custom offering by vishesh92 · Pull Request #8813 · apache/cloudstack

vishesh92 · 2024-03-20T15:16:04Z

Description

This PR fixes #8785.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2024-03-20T15:24:04Z

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 30.88%. Comparing base (308ed13) to head (654379a).
Report is 6 commits behind head on 4.19.

Files	Patch %	Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	85.71%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8813      +/-   ##
============================================
- Coverage     30.92%   30.88%   -0.05%     
+ Complexity    34290    34238      -52     
============================================
  Files          5355     5355              
  Lines        376634   376686      +52     
  Branches      54808    54813       +5     
============================================
- Hits         116480   116337     -143     
- Misses       244820   245053     +233     
+ Partials      15334    15296      -38

Flag	Coverage Δ
simulator-marvin-tests	`24.70% <0.00%> (-0.04%)`	⬇️
uitests	`4.38% <ø> (-0.01%)`	⬇️
unit-tests	`16.57% <85.71%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vishesh92 · 2024-03-20T16:21:10Z

@blueorangutan package

blueorangutan · 2024-03-20T16:22:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-20T17:21:28Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8984

vishesh92 · 2024-03-20T17:32:36Z

@blueorangutan test

blueorangutan · 2024-03-20T17:34:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-03-21T05:55:11Z

[SF] Trillian test result (tid-9538)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43030 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8813-t9538-kvm-centos7.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	`Failure`	336.79	test_safe_shutdown.py

sureshanaparti

minor question on dynamic offering, overall code lgtm

vishesh92 · 2024-03-26T12:09:52Z

@blueorangutan package

blueorangutan · 2024-03-26T12:12:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-26T13:16:21Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9042

vishesh92 · 2024-03-26T14:44:53Z

@blueorangutan test

blueorangutan · 2024-03-26T14:46:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-03-27T04:13:06Z

[SF] Trillian test result (tid-9587)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46806 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8813-t9587-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

vishesh92 · 2024-03-27T08:00:37Z

@blueorangutan package

blueorangutan · 2024-03-27T08:02:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-27T09:01:39Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9054

vishesh92 · 2024-03-27T11:21:54Z

@blueorangutan test

blueorangutan · 2024-03-27T11:24:04Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-03-27T23:46:52Z

[SF] Trillian test result (tid-9592)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43072 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8813-t9592-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland

clgtm

kiranchavala

LGTM, tested manually able to import to a custom offering

boring-cyborg bot added the component:api label Mar 20, 2024

vishesh92 force-pushed the fix-import-vm-and-delete-with-custom-offering branch from ceffd5f to 4812aeb Compare March 20, 2024 15:30

Fix VM import & VM delete with custom offering

863f14a

vishesh92 force-pushed the fix-import-vm-and-delete-with-custom-offering branch from 4812aeb to 863f14a Compare March 20, 2024 15:37

Fix test failures

a0a7adf

apache deleted a comment from blueorangutan Mar 20, 2024

vishesh92 added this to the 4.19.1.0 milestone Mar 21, 2024

vishesh92 requested a review from sureshanaparti March 21, 2024 10:49

sureshanaparti reviewed Mar 22, 2024

View reviewed changes

Comment thread server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java Outdated

sureshanaparti approved these changes Mar 22, 2024

View reviewed changes

sureshanaparti added the status:needs-testing label Mar 22, 2024

Resolve comments

ae79f02

vishesh92 commented Mar 27, 2024

View reviewed changes

Comment thread server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java Outdated

vishesh92 requested a review from kiranchavala March 27, 2024 07:36

vishesh92 added 2 commits March 27, 2024 13:10

fixup

74ed272

fixup

654379a

apache deleted a comment from blueorangutan Mar 27, 2024

DaanHoogland linked an issue Apr 3, 2024 that may be closed by this pull request

Unable to import qcow2 image present on shared/local to a custom offering #8785

Closed

vishesh92 requested a review from DaanHoogland April 4, 2024 11:33

DaanHoogland approved these changes Apr 4, 2024

View reviewed changes

kiranchavala approved these changes Apr 10, 2024

View reviewed changes

DaanHoogland merged commit c24c1a5 into apache:4.19 Apr 10, 2024

DaanHoogland deleted the fix-import-vm-and-delete-with-custom-offering branch April 10, 2024 09:29

DaanHoogland mentioned this pull request Apr 10, 2024

Unable to destroy/exunge a vm which errored during import #8786

Closed

yadvr mentioned this pull request Apr 30, 2024

Unable to import qcow2 image present on shared/local to a custom offering #8785

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024

Fix VM import & VM delete with custom offering (apache#8813)

952ebb3

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

vishesh92 commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vishesh92 commented Mar 20, 2024

Uh oh!

blueorangutan commented Mar 20, 2024

Uh oh!

blueorangutan commented Mar 20, 2024

Uh oh!

vishesh92 commented Mar 20, 2024

Uh oh!

blueorangutan commented Mar 20, 2024

Uh oh!

blueorangutan commented Mar 21, 2024

Uh oh!

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented Mar 26, 2024

Uh oh!

blueorangutan commented Mar 26, 2024

Uh oh!

blueorangutan commented Mar 26, 2024

Uh oh!

vishesh92 commented Mar 26, 2024

Uh oh!

blueorangutan commented Mar 26, 2024

Uh oh!

blueorangutan commented Mar 27, 2024

Uh oh!

Uh oh!

vishesh92 commented Mar 27, 2024

Uh oh!

blueorangutan commented Mar 27, 2024

Uh oh!

blueorangutan commented Mar 27, 2024

Uh oh!

vishesh92 commented Mar 27, 2024

Uh oh!

blueorangutan commented Mar 27, 2024

Uh oh!

blueorangutan commented Mar 27, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vishesh92 commented Mar 20, 2024 •

edited

Loading

codecov bot commented Mar 20, 2024 •

edited

Loading