Skip to content

Fix display of properties related to backup size#8845

Merged
DaanHoogland merged 4 commits intoapache:4.19from
scclouds:fix-display-of-backup-sizes
Apr 16, 2024
Merged

Fix display of properties related to backup size#8845
DaanHoogland merged 4 commits intoapache:4.19from
scclouds:fix-display-of-backup-sizes

Conversation

@bernardodemarco
Copy link
Copy Markdown
Member

Description

In the backup details page, the properties Size and Virtual Size are being displayed in bytes, and the property Disk size (in GB) is being displayed in kilobytes.

This PR converts these values into a more readable format, so that they match the displayed units. Thus, a pop-up has been added to each one of the properties to display their values in bytes.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before the changes

image

After the changes with closed pop-ups

image

After the changes with opened pop-ups

image

How Has This Been Tested?

  1. I created a VM backup with a DummyBackupProvider.
  2. I accessed the backup details page and verified that the properties values were converted correctly.

@weizhouapache
Copy link
Copy Markdown
Member

@bernardodemarco
do you have screenshots before/with this PR ?

@bernardodemarco
Copy link
Copy Markdown
Member Author

bernardodemarco commented Mar 28, 2024

@bernardodemarco do you have screenshots before/with this PR ?

Yes, they are in the PR's description.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.38%. Comparing base (6c6023b) to head (3426c76).
⚠️ Report is 606 commits behind head on 4.19.

❗ There is a different number of reports uploaded between BASE (6c6023b) and HEAD (3426c76). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (6c6023b) HEAD (3426c76)
simulator-marvin-tests 15 0
unit-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #8845       +/-   ##
============================================
- Coverage     30.13%   4.38%   -25.76%     
============================================
  Files          5355     361     -4994     
  Lines        376690   28666   -348024     
  Branches      54815    5000    -49815     
============================================
- Hits         113533    1258   -112275     
+ Misses       248185   27269   -220916     
+ Partials      14972     139    -14833     
Flag Coverage Δ
simulator-marvin-tests ?
uitests 4.38% <ø> (ø)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8845 (QA-JID-311)

Copy link
Copy Markdown
Member

@winterhazel winterhazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually verified in QA.

Before

image

After

image

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@JoaoJandre
Copy link
Copy Markdown
Contributor

@sureshanaparti can we merge this one?

@DaanHoogland DaanHoogland merged commit 7721133 into apache:4.19 Apr 16, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@DaanHoogland DaanHoogland added this to the 4.19.1.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants