Skip to content

upgrade: add unit tests from/to a security release#8870

Merged
yadvr merged 2 commits intoapache:4.18from
weizhouapache:4.18-add-tests-security-releases
Apr 4, 2024
Merged

upgrade: add unit tests from/to a security release#8870
yadvr merged 2 commits intoapache:4.18from
weizhouapache:4.18-add-tests-security-releases

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Apr 2, 2024

Description

This PR adds three unit tests

  • upgrade from 4.18.0.0 to a release which is NOT in the upgrade hierarchy
  • upgrade to latest version from a release which is NOT in the upgrade hierarchy
  • upgrade from a release to another release which are both NOT in the upgrade hierarchy

This is a followup of #7959

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.18.2.0 milestone Apr 2, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (8c62365) to head (499be35).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.18    #8870   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
- Complexity     9203     9204    +1     
=========================================
  Files          2724     2724           
  Lines        258153   258153           
  Branches      40236    40236           
=========================================
+ Hits          33982    33991    +9     
+ Misses       219866   219856   -10     
- Partials       4305     4306    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (8c62365) to head (546222b).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.18    #8870   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
- Complexity     9203     9204    +1     
=========================================
  Files          2724     2724           
  Lines        258153   258153           
  Branches      40236    40236           
=========================================
+ Hits          33982    33991    +9     
+ Misses       219866   219856   -10     
- Partials       4305     4306    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Copy Markdown
Contributor

This PR adds two unit tests

no, it add three uinit tests ;)

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weizhouapache
Copy link
Copy Markdown
Member Author

This PR adds two unit tests

no, it add three uinit tests ;)

right..
Let me update the description

@yadvr yadvr merged commit 7a9985b into apache:4.18 Apr 4, 2024
@DaanHoogland DaanHoogland deleted the 4.18-add-tests-security-releases branch April 4, 2024 09:27
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Apr 9, 2024
* upgrade: add unit tests from/to a security release

* upgrade: add unit test from a old security release to a new security release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants