Skip to content

api,ui: vm template format, fix vm info link#9094

Merged
weizhouapache merged 2 commits intoapache:4.19from
shapeblue:fix-vm-templateisolink
May 24, 2024
Merged

api,ui: vm template format, fix vm info link#9094
weizhouapache merged 2 commits intoapache:4.19from
shapeblue:fix-vm-templateisolink

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented May 21, 2024

Description

Fixes #9084

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

vm-template-iso-link.mp4

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#9084

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (87e7c57) to head (3440c3f).
Report is 6 commits behind head on 4.19.

Files Patch % Lines
...apache/cloudstack/api/response/UserVmResponse.java 33.33% 4 Missing ⚠️
...main/java/com/cloud/api/query/vo/UserVmJoinVO.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9094      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10987       -8     
============================================
  Files          5373     5373              
  Lines        469005   469034      +29     
  Branches      58953    60648    +1695     
============================================
- Hits          70198    70178      -20     
- Misses       391036   391089      +53     
+ Partials       7771     7767       -4     
Flag Coverage Δ
uitests 4.31% <ø> (ø)
unittests 15.66% <30.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

nice screenshot @shwstppr

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9654

@weizhouapache
Copy link
Copy Markdown
Member

@blueorangutan test rocky8 kvm-rocky8

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm and tested the link in a lab env

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-10236)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49562 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9094-t10236-kvm-rocky8.zip
Smoke tests completed. 128 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 425.66 test_events_resource.py
test_02_trigger_shutdown Failure 346.71 test_safe_shutdown.py
test_02_list_cpvm_vm Failure 0.05 test_ssvm.py
test_04_cpvm_internals Failure 0.06 test_ssvm.py

@DaanHoogland DaanHoogland reopened this May 23, 2024
@weizhouapache weizhouapache added this to the 4.19.1.0 milestone May 24, 2024
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache merged commit daf6b9d into apache:4.19 May 24, 2024
@DaanHoogland DaanHoogland deleted the fix-vm-templateisolink branch May 24, 2024 17:21
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@DaanHoogland DaanHoogland removed their assignment Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

Can't enable "Dynamically scalable" function for VM from ISO

4 participants