kvm: consider provisioning type for local data volumes

[shwstppr]

Description

Fixes #8644

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (c970141) to head (8be5c71).
Report is 1 commits behind head on 4.19.

Files	Patch %	Lines
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19    #9141    +/-   ##
==========================================
  Coverage     14.95%   14.96%            
- Complexity    10987    10989     +2     
==========================================
  Files          5373     5373            
  Lines        469165   469165            
  Branches      61164    61040   -124     
==========================================
+ Hits          70179    70190    +11     
+ Misses       391221   391205    -16     
- Partials       7765     7770     +5     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.67% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9728

[weizhouapache]

code lgtm

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10316)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46356 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9141-t10316-kvm-centos7.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	Failure	341.70	test_safe_shutdown.py

[yadvr]

LGTM didn't test it

[borisstoyanov]

LGTM, was able to get the correct size

[root@ref-trl-6778-k-Mr8-boris-stoyanov-kvm1 localstorage]# qemu-img info 35676ed8-a183-418c-975b-694b25282855
image: 35676ed8-a183-418c-975b-694b25282855
file format: qcow2
virtual size: 5 GiB (5368709120 bytes)
disk size: 5 GiB
cluster_size: 65536
Format specific information:
    compat: 1.1
    compression type: zlib
    lazy refcounts: false
    refcount bits: 16
    corrupt: false
    extended l2: false
[root@ref-trl-6778-k-Mr8-boris-stoyanov-kvm1 localstorage]#