Skip to content

server: search template name and display text if keyword is passed#9215

Merged
vishesh92 merged 1 commit intoapache:4.19from
weizhouapache:4.19-template-search-keyword
Jun 11, 2024
Merged

server: search template name and display text if keyword is passed#9215
vishesh92 merged 1 commit intoapache:4.19from
weizhouapache:4.19-template-search-keyword

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

This PR fixes #7590

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache marked this pull request as ready for review June 11, 2024 12:19
@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.67%. Comparing base (acae5c5) to head (0da7433).
Report is 1 commits behind head on 4.19.

Files Patch % Lines
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9215      +/-   ##
============================================
+ Coverage     14.96%   15.67%   +0.71%     
+ Complexity    11002    11001       -1     
============================================
  Files          5373     5010     -363     
  Lines        469309   440000   -29309     
  Branches      58607    55154    -3453     
============================================
- Hits          70231    68969    -1262     
+ Misses       391304   363400   -27904     
+ Partials       7774     7631     -143     
Flag Coverage Δ
uitests ?
unittests 15.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92 vishesh92 self-assigned this Jun 11, 2024
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Able to list templates by text in description by using keyword parameter after these changes. Verified the sql as well.

where clause before changes with keyword parameter

template_view.account_type != ?  AND template_view.hypervisor_type=? AND template_view.name LIKE ?  AND template_view.format != ?  AND template_view.template_state IN (?,?,?,?,?) 

After

template_view.account_type != ?  AND template_view.hypervisor_type=? AND  (template_view.name LIKE ?  OR template_view.display_text LIKE ? )  AND template_view.format != ?  AND template_view.template_state IN (?,?,?,?,?) 

@vishesh92 vishesh92 merged commit edf7394 into apache:4.19 Jun 11, 2024
@DaanHoogland DaanHoogland deleted the 4.19-template-search-keyword branch June 11, 2024 14:08
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

UI: searching for template with . (dot) in it's name - doesn't return any results

4 participants