server: search template name and display text if keyword is passed#9215
Merged
vishesh92 merged 1 commit intoapache:4.19from Jun 11, 2024
Merged
Conversation
yadvr
approved these changes
Jun 11, 2024
Member
Author
|
@blueorangutan package |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9215 +/- ##
============================================
+ Coverage 14.96% 15.67% +0.71%
+ Complexity 11002 11001 -1
============================================
Files 5373 5010 -363
Lines 469309 440000 -29309
Branches 58607 55154 -3453
============================================
- Hits 70231 68969 -1262
+ Misses 391304 363400 -27904
+ Partials 7774 7631 -143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vishesh92
approved these changes
Jun 11, 2024
Member
vishesh92
left a comment
There was a problem hiding this comment.
lgtm
Able to list templates by text in description by using keyword parameter after these changes. Verified the sql as well.
where clause before changes with keyword parameter
template_view.account_type != ? AND template_view.hypervisor_type=? AND template_view.name LIKE ? AND template_view.format != ? AND template_view.template_state IN (?,?,?,?,?) After
template_view.account_type != ? AND template_view.hypervisor_type=? AND (template_view.name LIKE ? OR template_view.display_text LIKE ? ) AND template_view.format != ? AND template_view.template_state IN (?,?,?,?,?)
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7590
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?