xenserver: attach regular iso with configdrive#9216
Conversation
Fixes apache#7902 This PR allows attaching a regular ISO to a VM when it already has the config drive ISO attached. Config-drive ISO is now attached with the SR name-label <VM-NAME>-CONFIGDRIVE-ISO. While regular ISOs continue to attach with SR name-label <VM-NAME>-ISO. VM which already have the configdrive ISO attached before this fix will return an appropriate error and will need to be stopped-start. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9216 +/- ##
============================================
- Coverage 14.96% 14.96% -0.01%
- Complexity 10994 10998 +4
============================================
Files 5373 5373
Lines 469248 469326 +78
Branches 58967 57730 -1237
============================================
- Hits 70220 70218 -2
- Misses 391253 391336 +83
+ Partials 7775 7772 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9887 |
|
@blueorangutan test rocky8 xcpng82 |
|
@shwstppr a [SL] Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-10425)
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10091 |
|
@blueorangutan test rocky8 xcpng82 |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-10628)
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
weizhouapache
left a comment
There was a problem hiding this comment.
lgtm
tested ok, after ISO is attached
# xe vm-cd-list vm=i-2-3-VM
CD 0 VBD:
uuid ( RO) : 3603b8ee-3cf0-f0a6-7777-8518eeaa66c3
vm-name-label ( RO): i-2-3-VM
empty ( RO): false
userdevice ( RW): 3
CD 0 VDI:
uuid ( RO) : 598a3c63-d73a-4a3a-983c-e816042d749f
name-label ( RW): 202-2-06d5aca2-0ed7-3890-ace9-0dd7e42f4d82.iso
sr-name-label ( RO): i-2-3-VM-ISO
virtual-size ( RO): 9369600
CD 1 VBD:
uuid ( RO) : da9d4657-dac7-44fb-34cf-3e3fd19f97dd
vm-name-label ( RO): i-2-3-VM
empty ( RO): false
userdevice ( RW): 4
CD 1 VDI:
uuid ( RO) : 1ae84149-3214-4530-8e4d-218c675790ff
name-label ( RW): i-2-3-VM.iso
sr-name-label ( RO): i-2-3-VM-CONFIGDRIVE-ISO
virtual-size ( RO): 405504
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10158 |
* xenserver: attach regular iso with configdrive Fixes apache#7902 This PR allows attaching a regular ISO to a VM when it already has the config drive ISO attached. Config-drive ISO is now attached with the SR name-label <VM-NAME>-CONFIGDRIVE-ISO. While regular ISOs continue to attach with SR name-label <VM-NAME>-ISO. VM which already have the configdrive ISO attached before this fix will return an appropriate error and will need to be stopped-start.
Description
Fixes #7902
This PR allows attaching a regular ISO to a VM when it already has the config drive ISO attached.
Config-drive ISO is now attached with the SR name-label
<VM-NAME>-CONFIGDRIVE-ISO. While regular ISOs continue to attach with SR name-label<VM-NAME>-ISO. VM which already have the configdrive ISO attached before this fix will return an appropriate error and will need to be stopped-start.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Checked CD list for VM on the hypervisor
How did you try to break this feature and the system with this change?