Skip to content

protect against missing service offering#9235

Merged
sureshanaparti merged 4 commits intoapache:4.19from
shapeblue:ghi9160-npeGettingServiceOffering
Jun 14, 2024
Merged

protect against missing service offering#9235
sureshanaparti merged 4 commits intoapache:4.19from
shapeblue:ghi9160-npeGettingServiceOffering

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Jun 13, 2024

Description

This PR...

Fixes: #9160

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland changed the title protect agains missing service offering protect against missing service offering Jun 13, 2024
@DaanHoogland DaanHoogland linked an issue Jun 13, 2024 that may be closed by this pull request
java.lang.NullPointerException while volume list #9160
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 14.96%. Comparing base (78ace3a) to head (bb8e8bb).
Report is 15 commits behind head on 4.19.

Files Patch % Lines
...ava/com/cloud/api/query/dao/VolumeJoinDaoImpl.java 0.00% 10 Missing ⚠️
.../com/cloud/service/dao/ServiceOfferingDaoImpl.java 0.00% 2 Missing ⚠️
server/src/main/java/com/cloud/api/ApiDBUtils.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              4.19    #9235       +/-   ##
============================================
+ Coverage     4.29%   14.96%   +10.66%     
- Complexity       0    11013    +11013     
============================================
  Files          363     5378     +5015     
  Lines        29347   469813   +440466     
  Branches      5126    59391    +54265     
============================================
+ Hits          1261    70290    +69029     
- Misses       27943   391737   +363794     
- Partials       143     7786     +7643
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.67% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

harikrishna-patnala
harikrishna-patnala approved these changes Jun 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@DaanHoogland DaanHoogland added this to the 4.19.1.0 milestone Jun 13, 2024
@DaanHoogland DaanHoogland mentioned this pull request Jun 13, 2024
Closed
@vladimirpetrov vladimirpetrov self-assigned this Jun 13, 2024
@vladimirpetrov
Copy link
Copy Markdown
Contributor

vladimirpetrov commented Jun 13, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 13, 2024

@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 13, 2024

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9921

@vladimirpetrov
Copy link
Copy Markdown
Contributor

vladimirpetrov commented Jun 13, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 13, 2024

@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 13, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9928

weizhouapache
weizhouapache approved these changes Jun 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

BryanMLima
BryanMLima reviewed Jun 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@BryanMLima BryanMLima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, overall, LGTM.

Comment thread server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java Outdated
@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Jun 14, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 14, 2024

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 14, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9944

vladimirpetrov
vladimirpetrov approved these changes Jun 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing, couldn't get a NPE even after nasty db manipulations.

sureshanaparti
sureshanaparti approved these changes Jun 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti sureshanaparti merged commit ed86dc9 into apache:4.19 Jun 14, 2024
@DaanHoogland DaanHoogland deleted the ghi9160-npeGettingServiceOffering branch June 14, 2024 10:23
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 20, 2024
@DaanHoogland @dhslove
protect against missing service offering (apache#9235)
fc3cd05 
* protect agains missing service offering

* search removed before assuming none

* import

* javadoc
@vishesh92 vishesh92 mentioned this pull request Jun 20, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BryanMLima BryanMLima BryanMLima left review comments

@yadvr yadvr yadvr approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@vladimirpetrov vladimirpetrov vladimirpetrov approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@vladimirpetrov vladimirpetrov

Labels

None yet

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

java.lang.NullPointerException while volume list

8 participants

@DaanHoogland @vladimirpetrov @blueorangutan @yadvr @harikrishna-patnala @sureshanaparti @BryanMLima @weizhouapache