Add support for functionality in hypervisor class by vishesh92 · Pull Request #9736 · apache/cloudstack

vishesh92 · 2024-09-27T06:27:54Z

Description

This PR adds support for functionality in hypervisor class. This solves 2 issues:

Allow configuring supported functionality of a hypervisor in Hypervisor class itself and remove custom logic of different hypervisors in the code. For now, we are only functionalities. Rest can be added later.
This allows custom hypervisor plugins to define their supported functionalities as well.

Types of changes

Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 · 2024-09-27T06:28:12Z

@blueorangutan package

blueorangutan · 2024-09-27T06:30:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-09-27T06:35:28Z

Codecov Report

Attention: Patch coverage is 45.71429% with 19 lines in your changes missing coverage. Please review.

Project coverage is 15.89%. Comparing base (bf2cede) to head (de41a6f).
Report is 81 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	10.00%	9 Missing ⚠️
...src/main/java/com/cloud/hypervisor/Hypervisor.java	68.18%	7 Missing ⚠️
...api/command/user/template/RegisterTemplateCmd.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20    #9736      +/-   ##
============================================
+ Coverage     15.78%   15.89%   +0.10%     
- Complexity    12550    12736     +186     
============================================
  Files          5625     5627       +2     
  Lines        491958   499324    +7366     
  Branches      60504    63253    +2749     
============================================
+ Hits          77663    79358    +1695     
- Misses       405836   411345    +5509     
- Partials       8459     8621     +162

Flag	Coverage Δ
uitests	`4.03% <ø> (-0.01%)`	⬇️
unittests	`16.60% <45.71%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-09-27T07:34:00Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11213

vishesh92 · 2024-09-30T06:28:05Z

@blueorangutan package

blueorangutan · 2024-09-30T06:30:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-30T07:33:54Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11233

vishesh92 · 2024-09-30T07:37:54Z

@blueorangutan test matrix

blueorangutan · 2024-09-30T07:40:04Z

@vishesh92 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2024-09-30T23:30:09Z

[SF] Trillian test result (tid-11576)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54729 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9736-t11576-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py

blueorangutan · 2024-10-01T00:32:04Z

[SF] Trillian test result (tid-11577)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 58863 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9736-t11577-kvm-ubuntu22.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_hostha_enable_ha_when_host_disabled	`Error`	3.96	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	305.15	test_hostha_kvm.py

shwstppr

Code LGTM

sureshanaparti

clgtm

sureshanaparti · 2024-10-03T13:10:38Z

@blueorangutan package

blueorangutan · 2024-10-03T13:12:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-03T14:11:08Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11267

vishesh92 · 2024-10-03T14:29:34Z

@blueorangutan test

blueorangutan · 2024-10-03T14:30:04Z

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-04T11:29:52Z

[SF] Trillian test result (tid-11606)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 73371 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9736-t11606-kvm-ol8.zip
Smoke tests completed. 137 look OK, 3 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	`Failure`	0.03	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.04	test_ssvm.py
test_01_secure_vm_migration	`Error`	305.98	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	352.50	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	356.25	test_vm_life_cycle.py
test_hostha_configure_default_driver	`Error`	365.95	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Failure`	855.46	test_hostha_kvm.py
test_hostha_kvm_host_degraded	`Error`	1982.62	test_hostha_kvm.py
test_hostha_kvm_host_degraded	`Error`	1982.62	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	193.74	test_hostha_kvm.py
test_remove_ha_provider_not_possible	`Error`	277.00	test_hostha_kvm.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py

vishesh92 · 2024-10-08T10:23:09Z

@blueorangutan package

blueorangutan · 2024-10-08T10:24:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-08T11:31:54Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11303

yadvr · 2024-10-09T07:03:05Z

@blueorangutan test

blueorangutan · 2024-10-09T07:04:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-10T04:54:09Z

[SF] Trillian test result (tid-11642)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 76268 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9736-t11642-kvm-ol8.zip
Smoke tests completed. 133 look OK, 2 have errors, 6 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	134.17	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.17	test_vm_life_cycle.py
test_04_rvpc_network_garbage_collector_nics	`Error`	2466.66	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	2466.67	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	55.13	test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown	`Error`	116.66	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

yadvr · 2024-11-29T07:34:28Z

@blueorangutan package

blueorangutan · 2024-11-29T07:36:04Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-29T08:35:05Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11648

weizhouapache · 2024-11-29T08:43:08Z

@blueorangutan package

blueorangutan · 2024-11-29T08:44:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-29T10:32:20Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11654

yadvr · 2024-12-02T04:55:53Z

@blueorangutan test

blueorangutan · 2024-12-02T04:58:04Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-12-02T20:40:50Z

[SF] Trillian test result (tid-11829)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54109 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9736-t11829-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_nonsecured_to_secured_vm_migration	`Error`	352.20	test_vm_life_cycle.py

* Add support for functionality in hypervisor class * Address comments * address comments

Add support for functionality in hypervisor class

e68bc29

boring-cyborg bot added the component:api label Sep 27, 2024

sureshanaparti reviewed Sep 27, 2024

View reviewed changes

Comment thread api/src/main/java/com/cloud/hypervisor/Hypervisor.java Outdated

sureshanaparti reviewed Sep 27, 2024

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

sureshanaparti reviewed Sep 27, 2024

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

vishesh92 added this to the 4.20.1.0 milestone Sep 27, 2024

Address comments

d1982db

vishesh92 force-pushed the hv-add-functionality-support branch from 65ee059 to d1982db Compare September 30, 2024 06:10

apache deleted a comment from blueorangutan Sep 30, 2024

vishesh92 requested a review from DaanHoogland October 1, 2024 07:18

yadvr requested review from shwstppr and removed request for DaanHoogland October 1, 2024 07:18

yadvr approved these changes Oct 1, 2024

View reviewed changes

sureshanaparti reviewed Oct 1, 2024

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

shwstppr approved these changes Oct 3, 2024

View reviewed changes

address comments

de41a6f

vishesh92 force-pushed the hv-add-functionality-support branch from 5c3593c to de41a6f Compare October 3, 2024 12:59

sureshanaparti approved these changes Oct 3, 2024

View reviewed changes

yadvr marked this pull request as ready for review October 9, 2024 07:02

DaanHoogland force-pushed the main branch from e5bd83e to 046870e Compare October 11, 2024 15:08

yadvr changed the base branch from main to 4.20 November 29, 2024 07:34

yadvr closed this Nov 29, 2024

yadvr reopened this Nov 29, 2024

yadvr merged commit 52e7b41 into apache:4.20 Dec 3, 2024

yadvr deleted the hv-add-functionality-support branch December 3, 2024 06:51

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024

Add support for functionality in hypervisor class (apache#9736)

44c11c1

* Add support for functionality in hypervisor class * Address comments * address comments

Pearl1594 added this to ACS 4.20.1 Mar 17, 2025

Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025

Conversation

vishesh92 commented Sep 27, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

vishesh92 commented Sep 27, 2024

Uh oh!

blueorangutan commented Sep 27, 2024

Uh oh!

codecov bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Sep 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vishesh92 commented Sep 30, 2024

Uh oh!

blueorangutan commented Sep 30, 2024

Uh oh!

blueorangutan commented Sep 30, 2024

Uh oh!

vishesh92 commented Sep 30, 2024

Uh oh!

blueorangutan commented Sep 30, 2024

Uh oh!

blueorangutan commented Sep 30, 2024

Uh oh!

blueorangutan commented Oct 1, 2024

Uh oh!

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Oct 3, 2024

Uh oh!

blueorangutan commented Oct 3, 2024

Uh oh!

blueorangutan commented Oct 3, 2024

Uh oh!

vishesh92 commented Oct 3, 2024

Uh oh!

blueorangutan commented Oct 3, 2024

Uh oh!

blueorangutan commented Oct 4, 2024

Uh oh!

vishesh92 commented Oct 8, 2024

Uh oh!

blueorangutan commented Oct 8, 2024

Uh oh!

blueorangutan commented Oct 8, 2024

Uh oh!

yadvr commented Oct 9, 2024

Uh oh!

blueorangutan commented Oct 9, 2024

Uh oh!

blueorangutan commented Oct 10, 2024

Uh oh!

yadvr commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

weizhouapache commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

codecov bot commented Sep 27, 2024 •

edited

Loading