Skip to content

Conversation

@dhaneesh646
Copy link
Contributor

Thanks for your contribution to Apache Commons! Your help is appreciated!

Added ProcessorTest.java to cover edge cases for isAarch64() and isRISCV().

  • Context: These methods previously had only 50% branch coverage (negative cases were missing).
  • Fix: Added specific unit tests to verify both true (matching architecture) and false (mismatched architecture) scenarios.
  • Result: mvn test jacoco:report now shows 100% coverage for Processor class.
  • Build: Ran full mvn build locally; verified Checkstyle and License headers.

Before ProcessorTest.java
before processor java

After ProcessorTest.java
after processor java

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dhaneesh646

Thank you for your PR. You might as well provide consistency in this new test and cover all is* methods.

@dhaneesh646
Copy link
Contributor Author

@garydgregory Updated ProcessorTest.java to cover all is* methods for consistency as requested. Ready for review!

@garydgregory garydgregory merged commit 5db0618 into apache:master Jan 22, 2026
20 checks passed
@garydgregory
Copy link
Member

Thank you @dhaneesh646 ; merged 🚀

garydgregory added a commit that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants