fix(build): Include build.rs in published crates #1199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a very niche build problem: depending on datafusion-python as an rlib, and then attempting to build on macOS.
Because of the presence of an 'include' configuration in Cargo.toml, everything else is excluded - as well as
build.rs
, which means the necessary pyo3 linker flags aren't set when building.I verified this fixes my build issue using a git dependency on datafusion-python:
Whereas just using the crates.io version doesn't build:
Note that you can verify build.rs is missing this way: