Support PostgreSQL C Functions with Multiple AS Parameters #2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments and flexible attribute order
iffyio
reviewed
Nov 14, 2025
Comment on lines
+10248
to
+10250
| let mut exprs = vec![first_expr]; | ||
| exprs.extend(self.parse_comma_separated(parse_string_expr)?); | ||
| Ok(Expr::Tuple(exprs)) |
Contributor
There was a problem hiding this comment.
oh, does wrapping this in a Tuple not include a parenthesis (first_expr, second_expr) when displaying the AST? wondering if/how we worked around that somehow in this case
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables parsing of PostgreSQL C language functions that specify both object file and link symbol in the
ASclause.Example
Fixes #2093