Allow to run ds-memory 3.0 on Java 25 #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes runtime Java version check - add Java 25 to the allow list, for
datasketches-memory3.0.I understand that Java 17/21/25 is not supported by datasketches-memory 3.0.2, but I'd like to run it in limited mode with Java 25, as it does on Java 17/21.
Verification:
Have done somke test with Apache Spark, see details at #270 (comment)
I can run integration tests with Spark if
datasketches-memorycan have a SNAPSHOT or RC release (includes this patch) available on a public Maven repo