[FLINK-38386][build] Fix attaching type annotations for jdk23+ #27009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
commented
Sep 18, 2025
Comment on lines
+182
to
+185
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
this fixes
Compilation failure
[ERROR] Cannot attach type annotations @org.checkerframework.checker.nullness.qual.Nullable to org.apache.calcite.tools.FrameworkConfig.getTraitDefs:
[ERROR] class file for com.google.common.collect.ImmutableList not found
snuyanzin
commented
Sep 18, 2025
| <groupId>joda-time</groupId> | ||
| <artifactId>joda-time</artifactId> | ||
| </exclusion> | ||
| <exclusion> |
There was a problem hiding this comment.
changes in this file fixes
Compilation failure
[ERROR] /java.base/java/lang/ThreadLocal.class: Cannot attach type annotations @org.checkerframework.checker.nullness.qual.Nullable to org.apache.calcite.util.trace.CalciteTrace.DYNAMIC_HANDLER:
[ERROR] class file for org.apache.calcite.linq4j.function.Function2 not found
snuyanzin
force-pushed
the
flink38386
branch
from
aeb6abf to
a4e18ff
Compare
snuyanzin
force-pushed
the
flink38386
branch
from
a4e18ff to
a6c1fd3
Compare
davidradl
approved these changes
Sep 24, 2025
github-actions
bot
added
the
community-reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Another step towards build with jdk25
Brief change log
pom.xml
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation