Skip to content

Conversation

jiexray
Copy link
Contributor

@jiexray jiexray commented Sep 22, 2025

WindowedStream allow registering AsyncTrigger for async state.

This pull request makes WindowedStream can register AsyncTrigger via trigger(). Before this pr, only internal window function (reduce, aggregate, ...) with enableAsyncState can register AsyncTrigger. After this pr, user can register AsyncTrigger in their own DataStream job via WindowedStream#trigger API.

Brief change log

  • WindowedStream adds WindowedStream#trigger whose parameter type is AsyncTrigger.

Verifying this change

  • Parameterize customize trigger() tests in WindowTranslationTest, where enableAsyncState is parameterized as true or false.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

@jiexray
Copy link
Contributor Author

jiexray commented Sep 22, 2025

@Zakelly Could you have a look at this pr, which resolves this ticket.

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 22, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! LGTM % CI. Will re-trigger it.

@Zakelly
Copy link
Contributor

Zakelly commented Sep 23, 2025

@flinkbot run azure

@jiexray
Copy link
Contributor Author

jiexray commented Sep 23, 2025

@flinkbot run azure

@jiexray
Copy link
Contributor Author

jiexray commented Sep 23, 2025

Thanks for the addition! LGTM % CI. Will re-trigger it.

@Zakelly Thank you for review. I have rebased on master and re-trigger CI.

@Zakelly Zakelly merged commit 0dc3220 into apache:master Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants